[CHANGES MADE] Visualizer steals focus for Media Keys (Stop/Start etc)

[ferropop]

If the Visualizer is focused, it prevents WACUP from receiving keys like Space (stop/start), forcing you to have to click on the player window to refocus...essentially defeating the purpose of using the keyboard.

[Eris Lund]

Which Visualizer plug-in were you running?

[ferropop]

MilkDrop.

Win10 LTSC.

[dro]

Because Milkdrop does things related to keyboard input (e.g. preset menu navigation & a few other things), it doesn't generically pass on keyboard presses it receives but doesn't handle to the main window unlike most of the other plug-in windows that WACUP provides.

The space key is used by Milkdrop in a long standing action to pick a different preset to render. I get that is at conflict of the usage of space within other changes that WACUP have introduced but I'm not sure about changing the default Milkdrop handling.

So I'm not sure what the best approach is to take with this.

-dro

[ferropop]

Because Milkdrop does things related to keyboard input (e.g. preset menu navigation & a few other things), it doesn't generically pass on keyboard presses it receives but doesn't handle to the main window unlike most of the other plug-in windows that WACUP provides.

The space key is used by Milkdrop in a long standing action to pick a different preset to render. I get that is at conflict of the usage of space within other changes that WACUP have introduced but I'm not sure about changing the default Milkdrop handling.

So I'm not sure what the best approach is to take with this.

-dro

Totally fair - would a key remap option be in the cards? Winamp (and now Reaper!) has championed customization from the beginning, and it would be great for those of us looking to really get in there to 'unmap' Space in Milkdrop to free it for it's new (much improved!) use.

[dro]

What I'll do is if the prefs option is set then milkdrop will adhere to it if stop/start is set & if not then it'll act like it's always done. That makes the most sense now I've had a bit more time to think about it especially as it'll still be possible to use shift/control + space (as there's nothing in the code to differentiate from those cases vs a plain space action) so only a minor behavioural change assuming its even an issue to start with.

-dro

[dro]

The changes for this are present in build 5864 & newer.

-dro