ver 1.99.54.24960 modern skin MAKI issue

[petormeat]

I updated my wacup as soon as I was notified of an update being possible. I usually use this modern skin that has transparency options and a specific menu window to select its color themes, this window is now not accesible, the transparency is gone and this shows up when using this skin (ignore that null pop-up at the beginning, it's always said that but the skin worked completely fine before, I am referring to the black and red error). Would like to know if anything is possible to fix this.

link to skin: https://www.deviantart.com/takanory/art/Quadelic-36391651

[dro]

Can you attach a copy of the skin as I don't have a deviantart account. Without knowing what version you were previously using & not being able to currently try the skin I'm going to assume it might be related to the current 24960 build changing from using the expat xml parser to the pugixml one & that it might not be doing something like expat did. The skin loading error is a gen_ff triggered messagebox & such skins can complete loading if there's some issues but things can then be unresponsive (it's like loading a web page & bits of the javascript are missing). The only fix I can suggest is going back to the prior build that was working for you (old downloads are linked back to on the preview download pages).

[petormeat]

Hello, thank you for the reply and sorry for the delay.
I attached the skin file as requested; I in fact did not know what wacup ver. I was using before but I remember updating 1 time before this last update brought me the error (with the crash fix available patch included); I'll be downgrading my wacup as suggested 

Edit: downgraded to ver 1.90.50.24496, no modern skin issues there

[dro]

If going back to 24496 works then it's not just due to the xml parser change. I know there were some reports of some of the transparent skins not working correctly (not that modern skins ever work 100% under wacup due to how it's gotten the gen_ff plug-in to work outside of winamp) but I wasn't aware of there also being xml parsing issues. Have got the skin & will hopefully get it resolved for the next preview build as the error is coming from one of the skin's xml files not having the expected xml headers so I need to adjust my handling to deal with that.

[dro]

I've got a simplish fix for you so the skin can work with 24960 by extracting the skin into a 'Quadelic' folder (a .wal file is just a .zip archive) within the wacup skins folder, then open the 'xml\configuration.xml' file within the 'Quadelic' folder & change the <elements/> to be </elements> & save it. Then select the folder extracted version of the skin (it should show with a folder icon next to its name in the skins menu) & that should then load correctly.


The problem is the / in the end elements part is invalid & what I now use for xml parsing doesn't like it but it's also possible that what had been used in earlier builds has been tightening up xml validation so might be why you had to go back a few builds to get it to work again (I've not tried the older builds to see what they're doing but it's a reasonable assumption with the changes that libexpat have kept making & which led me to want to drop it over all of it's security related churn). I still need to code in something that can handle this problem since it'll be expected for such skins to still be able to be loaded though imho the skin should never have been able to be loaded due to the error in the xml but that's another thing against libexpat being a lax parser.