Trying to convert AVS preset to MilkDrop, confusing results

[LigH]

I programmed a preset for WinAmp's AVS which I enjoy a lot. But I wondered if I could convert it to the MilkDrop 2 system. Well, that turned out to be not as easy. And I may have noticed a serious bug.

The MilkDrop 2 plugins in WACUP and foobar2000 differ obviously. While this reports version 2.41.4 and supports up to 4 custom shapes and waveforms which it saves explicitly, that one identifies as version 0.8.14 and supports up to 16 custom shapes and waveforms which it saves minimalistically. {PS: foo_MilkDrop2 is indeed an enhanced fork.}

The elephant in the room here is that the phase display I programmed displays a long diagonal line when the visualizer window frame is clicked or moved, and the right channel spectrum is not visible, so I have to assume that the right audio channel contains garbage values beyond 481 samples of the waveform window (looks fine up to 481, starts messing from 482 samples upwards).

{PS: From time to time there are even more mysterious issues. With the last update I installed yesterday, I see only one quadrant in use, as if all of the values are positive only.}

[sgard]

That right-channel garbage-past-481-samples thing sounds like a buffer/stride issue on the plugin's side rather than your preset. I ran into similar per-channel weirdness building my own visualizer that draws L/R separately instead of blending them - certain sample rates exposed offset bugs that a mono view never would. Does it happen consistently across audio sources, or only with specific sample rates/bit depths? Curious if it's a MilkDrop quirk or something upstream in WACUP's audio pipeline.

[Eris Lund]

What you're describing is a WACUP bug and has been addressed in a beta build, the fix for that will come whenever the next preview build is released

[LigH]

the fix for that will come whenever the next preview build is released

  Glad to be involved again! Looking forward to it.

[dro]

LigH: As a beta tester you've already got access to the dev build which has the noted vis plug-in handling fix.

sgard: It's a core handling issue where the internal data for the vis handling wasn't being copied correctly causing what is then provided to the vis plug-ins during their render calls to be wrong. Eris has already confirmed the fix with the current dev builds (i.e. what's being worked on after 24784 & which will be part of what is released as a new preview build soonish).

[LigH]

LigH: As a beta tester you've already got access to the dev build which has the noted vis plug-in handling fix.

Unfortunately it doesn't run. There was a "Side by side error" (WinSxs), asking me to check the Event Viewer. This one reported also an application error trying to run the x86 installer (WACUP_Full_v1_99_53_24784_x86.exe) so I have to assume that the installation got aborted due to a broken installer.

[dro]

That's not the dev build I'm referring to which you get from the beta releases sub-forum. Though why it's throwing a sxs error when I've not seen it from any of my various test installs I don't know as the installer itself doesn't tie into anything that's OS specific (outside of what it's been set to target i.e. Win7 & up) which the one discord report about it was basically lacking anything to try to debug it further.

[LigH]

OK, beta Dev-build.

Several crashes, uninstalls and fresh re-installs later (installer stops at the attempt to re-download original Winamp 5.666 libs when it tries to update an existing installation):

MilkDrop 2 works OK regarding the last bug.

But it behaves annoyingly for different reasons. So I doubt I will ever enjoy the port from AVS to MilkDrop2.

[dro]

Setting milkdrop to scan the whole of the %appdata% folder really isn't going to go well & that's the only obvious reason I can deem why it caused the crashes that I saw. If it's crashing during the install phase then I don't get crash reports from that. I also have little control if the attempt to re-acquire the needed 5.666 files from one of its installers fails which for the most part is just for the modern skin support now.

[LigH]

The crash in the MilkDrop plugin was due to trying to ascend the directory tree to get to the Documents. After a few wrong attempts to get me out of this culprit I found the correct INI file though.

[dro]

I've fixed some of the performance issue when trying to enumerate through too many folders with the newer dev build but more needs to be done to improve what's going on so it doesn't cause things to lock-up for a time as can still happen (at least it doesn't get stuck in a perpetual loop as I could quickly replicate).

[edit]
Have made some more changes which should now resolve it crashing when trying to interact with the preset browser whilst it's also trying to scan a folder (especially when it's the appdata one) along with it being much slower than it should do as part of sorting the presets that it's found (e.g. ~8sec to 0.1sec with the change made which leaves me with an ~5sec time to scan all of the appdata folder).