CD related feedback

[NotTheActualSean]

First off, thanks for working on WACUP, Winamp is excellent and it's great to see its legacy be maintained. It works almost flawlessly for me, but I have noticed a few things when playing Audio CDs. I'm using the 1.99.54.24960 32-bit build.

• Trying to play the CD from the left-hand side of the Media Library, via double-clicking or using the context menu items, only ever seems to work once. Once a CD is played via these methods, the only way to get them to work again seems to be restarting WACUP. Double-clicking seems flaky on Winamp 5.666, so there might be some reason behind it, but the context menu always worked there.
• Double-clicking/pressing Enter on a single track replaces the queue with just that track and plays it; on 5.666 it replaced the queue with the whole CD and started playing from the selected track, like with the local library.
• Ejecting a CD while on the CD page just causes the list to go blank; presumably, it should go to the "no disc is present" screen.
• If you insert a CD while on the Audio CD page. WACUP does not correctly refresh and list it, you have to navigate away and back to the CD. If the list was blank due to the above, it will show "no disc is present", and if it was already on that screen it stays there. 5.666 handles ejections and insertions properly.

There's also a couple of lesser things I may as well add while I'm here:

• 5.666 has an eject icon in the left list of the Media Library, and eject button on the bottom of the CD view. WACUP only has the context menu item.
• WACUP seems to pull CD album art from MusicBrainz; there's a "view artwork" button in the CD view, but doesn't seem associate it with track metadata, so it doesn't show in the Album Art window etc.

[dro]

I've not actively tested cd playback nor the views in a while so it's very likely from other core changes made since I did that things may have regressed / broken. Problems with artwork was also reported but I've still to get a drive hooked back up in my machine to do any testing of the handling.

As for comparing to 5.666, none of the cd or media library handling relates to it & hasn't used any 5.666 plug-ins to do it for long time now (since the x64 build appeared) so problems with any of this are all down to my code alone.

The enter / double-click handling has some control options on the media library root prefs page so that might get it to how you need as I can't remember what I set the default to be (there's things that I default differently compared to what winamp did as that's what I prefer most of the time).

[NotTheActualSean]

I have the media library options for double/click enter set to play and start with selected (see attachment), unless I missed something. It works as expected for the local libraries, but not for CDs, it always plays only the selected track.

I also just noticed there IS an eject button of the bottom of the library, it's just moved to the right; I completely missed it. But neither it nor the context menu entry seem to work reliably either... Unfortunately, I'm not sure why.

The number of us who still use CDs on PC is no doubt vanishingly small nowadays, I don't blame you for investing time elsewhere At least most of the issues have workarounds.