[FIXED] Duplicate Songs in Playlist

[thejay]

When there are duplicate titles in a playlist, under certain circumstances Wacup jumps to the wrong title while playing:

To reproduce:

Take the following sample playlist:

Song 1
Song 2
Song 3
Song 4
Song 5

Now add Song 2 again at the end:

Song 1
Song 2 (1)
Song 3
Song 4
Song 5
Song 2 (2)

Song 2 (2) is currently playing

Now add Song 6 at the end:

Song 1
Song 2 (1)
Song 3
Song 4
Song 5
Song 2 (2)
Song 6

Wacup now marks Song 2 (1) as the currently playing title and plays Song 3 instead of Song 6 next

[MourningStar]

... Now add Song 2 again at the end: ...

why?!?!??

One can do many things to screw things up. Perhaps if you provided a 'rational'
 explanation ...
 

[dro]

Are you using the 'q' action to override the order of what's being played (per the items with duplicate numbers noted against them) or just double-clicking on the duplicate item & then modifying the playlist? Also can you confirm what WACUP version & build type is being used.

[thejay]

... Now add Song 2 again at the end: ...

why?!?!??

One can do many things to screw things up. Perhaps if you provided a 'rational'
 explanation ...
 

I'm running Wacup in a pub. Some playlists contain hundreds of songs. A guest whishes for a song which was already played some hours ago and whoops the bug happens.

[thejay]

Are you using the 'q' action to override the order of what's being played (per the items with duplicate numbers noted against them) or just double-clicking on the duplicate item & then modifying the playlist? Also can you confirm what WACUP version & build type is being used.

Build is 1.99.43.23234 (32bit)

I'm sorry but I don't fully understand your question but I try to explain my workflow to reproduce the bug:
I've got a playlist. Now I drag and drop another song from the media library to play after the currently played song. If the currently played song is already in the playlist at an earlier position, the first occurance is marked as "now playing"

You can try it out quite easily:
1. Use an empty playlist.
2. Add the same song twice
3. Play the second song
4. Enqueue another song
5. The active song is now the first song

[dro]

The 'q' action allows for overriding the playback order so if you were using it then you'd likely know about it as it puts [1], [2], etc as part of the playlist item text. I'll have a look into this before doing the next build that I'm trying to get finished off & will update once I've either replicated or not.

[thejay]

Thanks for the clarification, I'm definitely not using the 'q' feature.
And also thanks for your efforts

[dro]

I've got a change for the next build which should avoid what's going on here. It's related to trying to keep the current playing item when there's other changes made to the playlist but it wasn't using the unique id that's assigned to a playlist item & instead it was just matching to the first string which is why it moved the current item to the first of the duplicated items. I've got to do a bit more clean-up but it doesn't seem to make anything else related to playlist vs current item handling break (e.g. undo is still oddly handled).

[thejay]

The current release seems to have fixed this bug. Thank you very much!

[dro]

Thanks for the confirmation it seems to be ok now.