Show Posts

This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.


Messages - GigaWatt

Pages: [1]
1
Tried the new version (Build #4346)... does pretty much the same thing, crashes :-\... except this time, it doesn't crash if you load just one MP3Pro file. If only one MP3Pro file is loaded in the playlist, it reads it's ID3 info correctly and looks like everything's kosher, but as soon as you hit play... nothing, nada, WACUP just hangs :-\. On the other hand, yes, it does crash if you load multiple MP3Pro files into the playlist. Reads the first one's ID3 tag and crashes when it starts to read the second one.

When loading regular MP3 files in the playlist, it just crashes, plain and simple... you load the file in the playlist, mark it, as soon as you do, it crashes :-\.

I don't have any email program installed, so it doesn't actually send the crash report. Is there any other way I can send you the crash report? I would also consider installing one if you think that's easier ;).

2
It's most likely the native unicode changes that appeared in 5.3 that started to cause issues but 5.8 beta working is just weird as that's got other changes which the older plug-in isn't going to know about & might just be more luck that it works than anything as plug-ins interacting with other plug-ins is always messy at the best of times.

Beats me, I don't know how, but it works :).

The plugin also has issues with scrolling through large/long MPRPro VBR files, but that's a totally different issue.

My point is, it has bugs and I'm not at all surprised that it doesn't work with anything above 5.24. Back in the day, many of us thought that Thompson would fix these issues in future releases. Unfortunately, the 1.3 version of the plugin was the last one ever released :(.

However I'm still seeing some issues like looking at it's file edit dialog which is crashing when closing it without making any changes & I've had the odd on closing error occur. Trying to have it use the normal (since 5.5) common file info / metadata editor support would probably be better than leaving it using it's own & the issues it's having (it's then just what happens if you try to edit the metadata when it's playing which isn't a good idea but people will do crazy things like that).

This would actually be a better option and would be appreciated if it could be implemented :).

So the new build it will have the changes in it that appear to allow it to work ok for me (still need to do the portable mode test) & if that helps fix the crashing for you then I'll look into using via in_mp3's common file info / metadata editor support.

I'll test it as soon as the release is ready ;).

Thanks for looking into this ;).

3
Can you provide me an example file please though it working in normal mode is odd as I intentionally have my dev install using a non-standard folder to try to catch cases were plug-ins are looking in default/hardcoded folder paths.

No prob, sample files attached ;).

I'll have to try a portable install but I've got a feeling the plug-in is doing something weird if it's trying to take over all mp3 handling so there might be an issue with it handing off to in_mp3 due to the age of the plug-in vs input plug-in api changes that have been made since 2005).

Yes, it takes over all MP3 handling. The idea was to have a single decoder for both MP3 and MP3 pro files. My guess is that the devs of the plugin were lazy and couldn't make a plugin that distinguishes between MP3 and MP3Pro files, so why not just make it decode both of them, nobody will notice the difference ::). I'm also guessing that Winamp's API changed considerably since 2004, 2005, and that's why the last version that allowed taking over all MP3 decoding was 5.24... and the plugin didn't work with a single version since 5.24 :(.

Up until 5.8 that is... oddly enough, it works great with 5.8 :D.

4
General Discussion / Re: Is this an open source project or a hack
« on: October 14, 2019, 12:47:33 AM »
The loader injects the wacup core dll into the winamp.original process when it's started as a suspended process with detours used since a few builds back to re-write the IAT to have that dll be the first one loaded so it can hook into things a lot earlier once it's allowed to run.

Cool, that's a great idea :).

There's then my age old favourite of apihijack used for some aspects, RAM patch of some aspects (not much at all unless I've no choice) & subclassing (in combination with some of the apihijack handling) to override the window messages as needed (mainly for ensuring replacement API handling via WACUP is used vs the original winamp code).

Super cool :). Did something similar to capture encrypted content from an application ;)... much easier than RCEing the whole thing from scratch, LOL :D.

It's not a permanent thing but just a means to keep things going whilst changing the engine as we're still driving. As I go along the aim is that there will be no winamp.original usage eventually nor the need for the loader & it'll then be back to a single exe (probably with the core maintained in a dll) & it'll be it's own thing separate of winamp but as winamp-compatible as I can make it (somewhat less of an issue when most plug-ins barely got beyond the 2.x api or any of the early 2.9x/5.x api additions).

Yeah, I agree, but why include the whole thing in a dll? I get it it was for security reasons, but I can't think of any other reason... and, as far as I know, WACUP and Winamp is (more or less) freeware ???.

WINE is fine & seems to have come on well & from some of the others who are using WACUP on WINE, it does a bit better than Winamp itself which wasn't always intentionally done but always nice to find out. Ideally there would be a way to do like is proposed but the design of the platforms just prevent that & other than some manner of proxying things such as from a mini WINE encapsulated handling to a native solution just rules it out.

Still haven't tested it on Linux/WINE, but will definitely do so ;) (probably at work, since we dual boot there all the time, not so much at home).

And the WINE encapsulated "loader" for Linux is actually a great idea :). Not having to install WINE and running WACUP almost natively :).

I have personal issues with open source as for the most part I see doing it as giving up on a project & some others have badly tainted my overall view of OSS as a negative experience. Then there's so much changing & being in flux at times I just don't think there's any benefit to me by going open source on the core or a number of the replacement plug-ins & everyone re-writes any released code so going for what works for my style isn't necessarily conducive for anyone else to help out with it being annoying for both sides. I know these sort of things can be resolved with time, setting down rules & all that but I'd also prefer to just get on with coding than the potential of managing things.

I see your point and yes, I do agree that managing open source code can be time consuming... heck, I know a few pretty popular open source projects that don't even have forums because they hate the idea of maintaining/managing the GitHub page and the forum at the same time :-\. Hell, I'm having a hard time just maintaining a single forum, LOL :D.

And yeah, authors do usually release the source of popular projects only when they finally give up on the project. But, I see that as a good thing. Classic Shell is a perfect example of that ;). Open Shell wouldn't exist if the author didn't publish the Classic Shell source on GitHub ;).

I have not ruled it out as something that can be considered later on but that would most likely happen when I loose interest &/or can no longer work on WACUP full-time which with the likes of patreon & other donations & being frugal in how I live to start with not being something I need to think about for a few more years.

Exactly what I was thinking of politely asking you, but you already gave me the answer :). It would mean a lot to a lot of people if you release the source for WACUP if/when you decide to stop working on WACUP ;).

Guilty as charged. I was a 3rd party plug-in developer from late 2003 (used Winamp from 1999) & had the JTFE plug-in included in the early 5.x builds in 2004 (non-paid addition which is why it was allowed to have a donation button on its preferences).

Oh, so you're the on that, thank god, thought of including JTFE in the install, LOL :D.

It's good things started with a former dev ;). You're more familiar with the guts of the whole thing, so you're probably most qualified to run this whole thing ;).

Good luck and I hope more people start joining in and participating in something that (at least in my mind) will have a great future :).

5
General Discussion / Re: Adding WACUP to the Default Programs list
« on: October 14, 2019, 12:08:14 AM »
Actually... you were right ;). I forgot about this part :P :D.

Code: [Select]
[HKEY_LOCAL_MACHINE\SOFTWARE\Winamp]
@="C:\\Program Files (x86)\\Winamp"

[HKEY_LOCAL_MACHINE\SOFTWARE\Wow6432Node\Winamp]
@="C:\\Program Files (x86)\\Winamp"

It should be like this for an x86 OS.

Code: [Select]
[HKEY_LOCAL_MACHINE\SOFTWARE\Winamp]
@="C:\\Program Files\\Winamp"

[HKEY_LOCAL_MACHINE\SOFTWARE\Wow6432Node\Winamp]
@="C:\\Program Files\\Winamp"

So, the whole reg hack should be like this for an x86 OS ;).

Code: [Select]
Windows Registry Editor Version 5.00

[HKEY_LOCAL_MACHINE\SOFTWARE\Winamp]
@="C:\\Program Files\\Winamp"

[HKEY_LOCAL_MACHINE\SOFTWARE\Winamp\Capabilities]
"ApplicationDescription"="Winamp"
"ApplicationName"="Winamp"

[HKEY_LOCAL_MACHINE\SOFTWARE\Winamp\Capabilities\FileAssociations]
".aif"="Winamp.File"
".aiff"="Winamp.File"
".aifc"="Winamp.File"
".aifr"="Winamp.File"
".ape"="Winamp.File"
".aif"="Winamp.File"
".mac"="Winamp.File"
".apl"="Winamp.File"
".au"="Winamp.File"
".snd"="Winamp.File"
".cda"="Winamp.File"
".flac"="Winamp.File"
".gsm"="Winamp.File"
".mid"="Winamp.File"
".midi"="Winamp.File"
".rmi"="Winamp.File"
".kar"="Winamp.File"
".miz"="Winamp.File"
".mod"="Winamp.File"
".mdz"="Winamp.File"
".nst"="Winamp.File"
".stm"="Winamp.File"
".stz"="Winamp.File"
".s3m"="Winamp.File"
".s3z"="Winamp.File"
".it"="Winamp.File"
".itz"="Winamp.File"
".xm"="Winamp.File"
".xmz"="Winamp.File"
".mtm"="Winamp.File"
".ult"="Winamp.File"
".669"="Winamp.File"
".far"="Winamp.File"
".amf"="Winamp.File"
".okt"="Winamp.File"
".ptm"="Winamp.File"
".mp3"="Winamp.File"
".mp2"="Winamp.File"
".mp1"="Winamp.File"
".aac"="Winamp.File"
".vlb"="Winamp.File"
".m4a"="Winamp.File"
".als"="Winamp.File"
".mpc"="Winamp.File"
".mp+"="Winamp.File"
".mpp"="Winamp.File"
".nsf"="Winamp.File"
".nsfe"="Winamp.File"
".pac"="Winamp.File"
".ram"="Winamp.File"
".ra"="Winamp.File"
".rm"="Winamp.File"
".tta"="Winamp.File"
".vgm"="Winamp.File"
".vgz"="Winamp.File"
".ogg"="Winamp.File"
".opu"="Winamp.File"
".opus"="Winamp.File"
".vqf"="Winamp.File"
".avr"="Winamp.File"
".caf"="Winamp.File"
".htk"="Winamp.File"
".iff"="Winamp.File"
".mat"="Winamp.File"
".paf"="Winamp.File"
".pvf"="Winamp.File"
".raw"="Winamp.File"
".sd2"="Winamp.File"
".sds"="Winamp.File"
".sf"="Winamp.File"
".voc"="Winamp.File"
".w64"="Winamp.File"
".wav"="Winamp.File"
".xi"="Winamp.File"
".ac3"="Winamp.File"
".dts"="Winamp.File"
".wma"="Winamp.File"
".wv"="Winamp.File"
".m3u"="Winamp.PlayList"
".pls"="Winamp.PlayList"
".asx"="Winamp.PlayList"
".wax"="Winamp.PlayList"
".wmx"="Winamp.PlayList"
".wvx"="Winamp.PlayList"
".wpl"="Winamp.PlayList"
".b4s"="Winamp.PlayList"
".bpl"="Winamp.PlayList"

[HKEY_LOCAL_MACHINE\SOFTWARE\RegisteredApplications]
"Winamp"="Software\\Winamp\\Capabilities"

6
I did some testing and you're right. The MP3Pro plugin does load, BUT only if WACUP is installed in classical mode (not portable, and the screenshot I posted earlier was from a portable install). After installing WACUP in classical mode on Win 8.1 x86 and Win 10 LTSC 2019 x64 VMs, yes, the plugin did load ;).



But, WACUP crashes as soon as you try and play a regular MP3 file and crashes as soon as you select an MP3Pro file in the playlist.




7
General Discussion / Re: Is this an open source project or a hack
« on: October 12, 2019, 07:21:22 AM »
You'll need to PM me some details re: the failed user account as I don't appear to have any obvious non-activated accounts.

Sent ;).

WACUP is a mismatch of new plug-ins, old plug-ins, some closed source, some open source, live code patches, hard-coded code patches, original compiled code & other aspects in-between that. You could say hack for some parts but then most software & original handling within Winamp is deemed a hack ;)

From what I've concluded, it's using inline patching (loader, RAM patch) as a deployment method. Is this correct?

I don't have plans to go 100% open source & in all honestly a solution for Linux is much better done directly than trying to re-work Windows specific code as Winamp / WACUP & related plug-ins have been coded. For the most part, most Linux solutions can do the classic 2.x style skins & that's alright for most. Plug-ins however aren't platform agnostic so you couldn't do things like running existing Winamp plug-ins within a native Linux / other platform as they're different designs of being run (sure some of the compiled code can probably do it but it's the equivalent of putting diesel into a petrol engine - both are fuel but it's not a good idea to mix & match).

Yeah, I thought it might be a bit far fetched to try and make the native Windows closed source plugins work with "native" Winamp Linux binaries (if they were released, some day) :P :D. Still, a nice idea IMO :). WINE does a perfectly good job so far, and yeah, I'm not using anything else than the default Winamp 2.x skin, so things are fine the way they are now IMO :).

But why not go fully open source? I mean... I can understand in places where there are licenses attached to binaries, but why not go fully open source if every module in Winamp gets replaced with adequate code and does everything that Winamp 5.x did (and much more in some cases)?

And one other question. I read on the official Winamp forum that you're a former Winamp dev. Is this correct?

8
General Discussion / Re: Adding WACUP to the Default Programs list
« on: October 12, 2019, 06:56:39 AM »
A caveat is that what's provided (thanks!) is for a 64-bit version of the OS.

An x86 OS wouldn't even look at the extra Wow6432Node part in the reg keys anyway ;). That's why I just said to "do it in both places", so I don't have to explain why changing something in one place doesn't necessarily mean that it will work on both x86 and x64... and why changing the extensions in only the Wow6432Node key will not work if the reg file is imported on an x86 OS, LOL :D.

If only using WACUP then it's fine though the WACUP solution is going to change some of those values so it's simpler to run Winamp & WACUP side by side (primarily for testing purposes).

Yeah, I'm actually using WACUP like that now :). Just thought that this might come in handy when doing some customizing or wanting to run WACUP as a portable player ;). Just double click on the reg entry and bam, you're done setting up WACUP as a default audio player on that particular PC ;).

9
Actually, the plugin didn't work with anything above Winamp 5.24... until the Winamp 5.8 beta came out. It works as expected with Winamp 5.8 (currently using it with Winamp 5.8 ). So, yeah, it didn't work with Winamp 5.666 either (there's something in those numbers :P :D).

Plugin attached ;).

EDIT: Do write if you need a sample MP3Pro file ;).

10
General Discussion / Adding WACUP to the Default Programs list
« on: October 11, 2019, 07:22:57 PM »
I did a registry hack a while back, when I was stuck using Winamp 5.24, so I thought I'd share it here :). It should work with WACUP too :). You should just change the default location of the program (if it's not located in C:\Program Files (x86)\Winamp that is ;)). The audio/video file extensions are editable, you just have to add or remove the extensions you'd like to associate with WACUP in the reg file. You have to edit them in two places, both in the HKEY_LOCAL_MACHINE\SOFTWARE\Winamp\Capabilities\FileAssociations key and the HKEY_LOCAL_MACHINE\SOFTWARE\Wow6432Node\Winamp\Capabilities\FileAssociations key ;).

Code: [Select]
Windows Registry Editor Version 5.00

[HKEY_LOCAL_MACHINE\SOFTWARE\Winamp]
@="C:\\Program Files (x86)\\Winamp"

[HKEY_LOCAL_MACHINE\SOFTWARE\Wow6432Node\Winamp]
@="C:\\Program Files (x86)\\Winamp"

[HKEY_LOCAL_MACHINE\SOFTWARE\Winamp\Capabilities]
"ApplicationDescription"="Winamp"
"ApplicationName"="Winamp"

[HKEY_LOCAL_MACHINE\SOFTWARE\Wow6432Node\Winamp]
"ApplicationDescription"="Winamp"
"ApplicationName"="Winamp"

[HKEY_LOCAL_MACHINE\SOFTWARE\Winamp\Capabilities\FileAssociations]
".aif"="Winamp.File"
".aiff"="Winamp.File"
".aifc"="Winamp.File"
".aifr"="Winamp.File"
".ape"="Winamp.File"
".aif"="Winamp.File"
".mac"="Winamp.File"
".apl"="Winamp.File"
".au"="Winamp.File"
".snd"="Winamp.File"
".cda"="Winamp.File"
".flac"="Winamp.File"
".gsm"="Winamp.File"
".mid"="Winamp.File"
".midi"="Winamp.File"
".rmi"="Winamp.File"
".kar"="Winamp.File"
".miz"="Winamp.File"
".mod"="Winamp.File"
".mdz"="Winamp.File"
".nst"="Winamp.File"
".stm"="Winamp.File"
".stz"="Winamp.File"
".s3m"="Winamp.File"
".s3z"="Winamp.File"
".it"="Winamp.File"
".itz"="Winamp.File"
".xm"="Winamp.File"
".xmz"="Winamp.File"
".mtm"="Winamp.File"
".ult"="Winamp.File"
".669"="Winamp.File"
".far"="Winamp.File"
".amf"="Winamp.File"
".okt"="Winamp.File"
".ptm"="Winamp.File"
".mp3"="Winamp.File"
".mp2"="Winamp.File"
".mp1"="Winamp.File"
".aac"="Winamp.File"
".vlb"="Winamp.File"
".m4a"="Winamp.File"
".als"="Winamp.File"
".mpc"="Winamp.File"
".mp+"="Winamp.File"
".mpp"="Winamp.File"
".nsf"="Winamp.File"
".nsfe"="Winamp.File"
".pac"="Winamp.File"
".ram"="Winamp.File"
".ra"="Winamp.File"
".rm"="Winamp.File"
".tta"="Winamp.File"
".vgm"="Winamp.File"
".vgz"="Winamp.File"
".ogg"="Winamp.File"
".opu"="Winamp.File"
".opus"="Winamp.File"
".vqf"="Winamp.File"
".avr"="Winamp.File"
".caf"="Winamp.File"
".htk"="Winamp.File"
".iff"="Winamp.File"
".mat"="Winamp.File"
".paf"="Winamp.File"
".pvf"="Winamp.File"
".raw"="Winamp.File"
".sd2"="Winamp.File"
".sds"="Winamp.File"
".sf"="Winamp.File"
".voc"="Winamp.File"
".w64"="Winamp.File"
".wav"="Winamp.File"
".xi"="Winamp.File"
".ac3"="Winamp.File"
".dts"="Winamp.File"
".wma"="Winamp.File"
".wv"="Winamp.File"
".m3u"="Winamp.PlayList"
".pls"="Winamp.PlayList"
".asx"="Winamp.PlayList"
".wax"="Winamp.PlayList"
".wmx"="Winamp.PlayList"
".wvx"="Winamp.PlayList"
".wpl"="Winamp.PlayList"
".b4s"="Winamp.PlayList"
".bpl"="Winamp.PlayList"

[HKEY_LOCAL_MACHINE\SOFTWARE\Wow6432Node\Winamp\Capabilities\FileAssociations]
".aif"="Winamp.File"
".aiff"="Winamp.File"
".aifc"="Winamp.File"
".aifr"="Winamp.File"
".ape"="Winamp.File"
".aif"="Winamp.File"
".mac"="Winamp.File"
".apl"="Winamp.File"
".au"="Winamp.File"
".snd"="Winamp.File"
".cda"="Winamp.File"
".flac"="Winamp.File"
".gsm"="Winamp.File"
".mid"="Winamp.File"
".midi"="Winamp.File"
".rmi"="Winamp.File"
".kar"="Winamp.File"
".miz"="Winamp.File"
".mod"="Winamp.File"
".mdz"="Winamp.File"
".nst"="Winamp.File"
".stm"="Winamp.File"
".stz"="Winamp.File"
".s3m"="Winamp.File"
".s3z"="Winamp.File"
".it"="Winamp.File"
".itz"="Winamp.File"
".xm"="Winamp.File"
".xmz"="Winamp.File"
".mtm"="Winamp.File"
".ult"="Winamp.File"
".669"="Winamp.File"
".far"="Winamp.File"
".amf"="Winamp.File"
".okt"="Winamp.File"
".ptm"="Winamp.File"
".mp3"="Winamp.File"
".mp2"="Winamp.File"
".mp1"="Winamp.File"
".aac"="Winamp.File"
".vlb"="Winamp.File"
".m4a"="Winamp.File"
".als"="Winamp.File"
".mpc"="Winamp.File"
".mp+"="Winamp.File"
".mpp"="Winamp.File"
".nsf"="Winamp.File"
".nsfe"="Winamp.File"
".pac"="Winamp.File"
".ram"="Winamp.File"
".ra"="Winamp.File"
".rm"="Winamp.File"
".tta"="Winamp.File"
".vgm"="Winamp.File"
".vgz"="Winamp.File"
".ogg"="Winamp.File"
".opu"="Winamp.File"
".opus"="Winamp.File"
".vqf"="Winamp.File"
".avr"="Winamp.File"
".caf"="Winamp.File"
".htk"="Winamp.File"
".iff"="Winamp.File"
".mat"="Winamp.File"
".paf"="Winamp.File"
".pvf"="Winamp.File"
".raw"="Winamp.File"
".sd2"="Winamp.File"
".sds"="Winamp.File"
".sf"="Winamp.File"
".voc"="Winamp.File"
".w64"="Winamp.File"
".wav"="Winamp.File"
".xi"="Winamp.File"
".ac3"="Winamp.File"
".dts"="Winamp.File"
".wma"="Winamp.File"
".wv"="Winamp.File"
".m3u"="Winamp.PlayList"
".pls"="Winamp.PlayList"
".asx"="Winamp.PlayList"
".wax"="Winamp.PlayList"
".wmx"="Winamp.PlayList"
".wvx"="Winamp.PlayList"
".wpl"="Winamp.PlayList"
".b4s"="Winamp.PlayList"
".bpl"="Winamp.PlayList"

[HKEY_LOCAL_MACHINE\SOFTWARE\RegisteredApplications]
"Winamp"="Software\\Winamp\\Capabilities"

[HKEY_LOCAL_MACHINE\SOFTWARE\Wow6432Node\RegisteredApplications]
"Winamp"="Software\\Winamp\\Capabilities"

Just copy/paste the code in a plain text document, change the extension to .reg (instead of .txt), edit the registry file to your liking using any text editor, save the .reg file and import it in the registry (double click ;)), that's it :).

11
It works in Winamp 5.8, but not in WACUP 1.0.8.4334. Tried several different ways, including completely removing the native mp3 decoder.


12
General Discussion / Re: Is this an open source project or a hack
« on: October 11, 2019, 06:56:58 PM »
Thought so ;)... just wanted to make sure that I didn't (somehow :P :D) miss Winamp going open source, LOL :D.

I installed WACUP last night... I have to say, it's pretty much how Winamp used to be, just the way I liked it :). I still have a few more things to check out, like if the MP3Pro plugin works like it should (it didn't work at all, up until v5.8, so I was stuck at v5.24 :-\), which is a must, at least for me (I converted all my music to MP3Pro years back and... well, I just don't want to have to recode everything again) and see if I can adjust the ID3 tag editor to show both ID3 v1 and v2, side by side ;).

In any case, this is a great project :). Love the fact the some people decided to finally stand up and continue working on something that has been a part of our lives since... well, as long as I can remember :). I hate seeing good things go down the drain, and IMO, Winamp was definitely going down the drain :-\.

It would be cool though to see if all of the parts of the player get replaced with open source code :). Then, we could finally start working on a native Linux build :). Even cooler, a native Linux build that can use native Windows libraries that are closed source, like the MP3Pro plugin for example ;).

13
General Discussion / Is this an open source project or a hack
« on: October 11, 2019, 03:53:08 AM »
I think the question is pretty simple... I tried to find some more info regarding the project, but this site and forum was all searches came up with :-\.

EDIT: I tried to register an account here under a different username, but the activation email never arrived... I might have typed the email address wrong :P :D... could the forum staff please look into it, thanks :).

Pages: [1]