WACUP

General => Wishlist / Feature Requests => Topic started by: MourningStar on February 09, 2019, 02:11:47 AM

Title: Album Art for Streaming - Module Rename
Post by: MourningStar on February 09, 2019, 02:11:47 AM
Hi -

I am no technocrat and I don't know if this is even remotely possible.

1 - I listen to several dozen different on-line music, talk, preachin', etc. stations and think it would be cool if I could assign some relative image/artwork to each stream. I notice that in 'edit bookmarks' there are two entry boxes, one for the url and one for user customization of the bookmark's name/ title. Perhaps here is where a 3rd entry box can be created to specify a path to an image from  the computer or from the web and then maybe store the images in the app's directory for reduced load times/cpu overhead. I don't know if this is hard-coded, but a green image of the WACUP logo currently appears when I am listening to online stations, so maybe?

2 - What is the likelihood of being able to rename the modules? Not to be rude or anything but I would like to rename the Main window to something other than WACUP and Enhancer to something else as well.

thx,
-Marc.
Title: Re: Album Art for Streaming - Module Rename
Post by: victhor on February 09, 2019, 02:52:16 PM
2 - What is the likelihood of being able to rename the modules? Not to be rude or anything but I would like to rename the Main window to something other than WACUP and Enhancer to something else as well.

I think I can answer this one. For the WACUP word, where do you want it to take it off from? From the upper left corner of Big Bento Modern it is toggable from the Skin settings (Main menu - Skin settings - Appearance > disable "Show WACUP logo"). From menus and such, is a totally different matter, which I don't think is possible.

Enhancer uses a Standard Windows IIRC, so to remove the title from there you could edit one of the skin's file, but it will remove ALL names of the standard windows (like "Jump to file", "Queue manager" and all plugins that opens on external windows)... is that acceptable for you? Or is not a good trade?

EDIT: Stupid me, I've just seen on the other thread that you're using Classic skin. I think your only chance is to edit the graphic files..
Title: Re: Album Art for Streaming - Module Rename
Post by: MourningStar on February 09, 2019, 05:13:19 PM
. I think your only chance is to edit the graphic files..
thx for reply. where are the files and what editor do you suggest? I do have Photoshop.
Title: Re: Album Art for Streaming - Module Rename
Post by: ariszlo on February 09, 2019, 09:48:27 PM
where are the files and what editor do you suggest?

Modifying a skin's graphics is only ok for your own use. You should not pass a modified skin on without the original author's permission. But it is much better to make your own skin. Download the Skinner Atlas (http://web.archive.org/web/20131120210124/http://www.winamp.com/skin/skinner-atlas/126738) skin, unzip it and read the README.

You may also want to study the Winamp 5 base skin (http://download.nullsoft.com/winamp/skin-dev/).
Title: Re: Album Art for Streaming - Module Rename
Post by: MourningStar on February 09, 2019, 10:09:49 PM
where are the files and what editor do you suggest?

Modifying a skin's graphics is only ok for your own use. You should not pass a modified skin on without the original author's permission. But it is much better to make your own skin. Download the Skinner Atlas (http://web.archive.org/web/20131120210124/http://www.winamp.com/skin/skinner-atlas/126738) skin, unzip it and read the README.

You may also want to study the Winamp 5 base skin (http://download.nullsoft.com/winamp/skin-dev/).
OK - Apparently you missed the first 4 words of the op. Loading an image into photoshop, playing around and saving the finished image is my limit. And why would I want to distribute my personal artwork? Also, changing the textual name of the module is really not much of a graphic mod imo. Finally, I am much much more interested in the first item.
Title: Re: Album Art for Streaming - Module Rename
Post by: ariszlo on February 09, 2019, 10:43:04 PM
OK - Apparently you missed the first 4 words of the op. Loading an image into photoshop, playing around and saving the finished image is my limit.

Then just accept it as it is. The title bar image of the WACUP Classic Skin is in winamp_res.dll. I don't have PhotoShop but I doubt you can edit dlls with it.

Also, changing the textual name of the module is really not much of a graphic mod imo.

The titlebars of classic skins are images.

Finally, I am much much more interested in the first item.

OK. I cannot answer that. Maybe somebody else?
Title: Re: Album Art for Streaming - Module Rename
Post by: victhor on February 09, 2019, 10:52:15 PM
Huh.. I almost forgot about this, I'll reply more in detail when I get home.
Title: Re: Album Art for Streaming - Module Rename
Post by: MourningStar on February 10, 2019, 12:05:43 AM
The title bar image of the WACUP Classic Skin is in winamp_res.dll. I don't have PhotoShop but I doubt you can edit dlls with it.
perhaps there is an image in the dll that could be extracted, modified  with a graphics editor and replaced with the modified version?
Title: Re: Album Art for Streaming - Module Rename
Post by: victhor on February 10, 2019, 12:15:20 AM
Modifying a skin's graphics is only ok for...

He never mentioned he would share the modded file.. (https://emojipedia-us.s3.dualstack.us-west-1.amazonaws.com/thumbs/60/twitter/180/thinking-face_1f914.png)

thx for reply. where are the files and what editor do you suggest? I do have Photoshop.

Damn.. I forgot the classic skin is embeded on the dll. So you'll be better off just using the original Winamp Classic skin if you can get it from somewhere else.. (I couldn't find it from a quick look around)
Title: Re: Album Art for Streaming - Module Rename
Post by: MourningStar on February 10, 2019, 12:43:05 AM
Well, I looked in the winamp_res.dll. Located only one image in it that might be the one, modified it and put it back. Re-booted the machine, fired up WACUP but no change (yes, I did make a backup of the original). fwiw I have attached the modded image for your pleasure (and as indicated earlier, not much of a mod at that).
Title: Re: Album Art for Streaming - Module Rename
Post by: victhor on February 10, 2019, 12:49:00 AM
No, it won't work because it's not it, the skin is made of pieces, the one with "WACUP" on it is smaller IIRC.
Maybe on Monday DrO can throw you a line with the file. But I'm pretty sure it's out there. Just can't look around too much because.. It's weekend, and weekend makes people go on and off computers, even me hehe.
Title: Re: Album Art for Streaming - Module Rename
Post by: ariszlo on February 10, 2019, 05:58:13 AM
Located only one image in it that might be the one

No, it is not that. It is this.

Still, you had better convert the extracted images to bmp format and rename them using the filenames of the Winamp 5 base skin (http://download.nullsoft.com/winamp/skin-dev/) and either keep the files in a subdirectory inside the Skins directory or zip them.

If you just put the modified png back to the dll then you will lose the changes when WACUP is updated.

He never mentioned he would share the modded file..

No, he hasn't.
Title: Re: Album Art for Streaming - Module Rename
Post by: ariszlo on February 10, 2019, 08:40:07 AM
As for your first question, it does not usually work out well if you raise more than one topic in a single post. Normally, only one of your questions will be answered.

To get answers to your first question, you had better open a new thread with a new title. Something like "Classic Art plugin (http://winampplugins.co.uk/gen_classicart/) with custom stream art" would likely draw DrO's attention to it, who is the maintainer of that plugin.
Title: Re: Album Art for Streaming - Module Rename
Post by: dro on February 10, 2019, 11:45:33 AM
I can split / answer the thread properly later tonight (just got that pesky thing of a weekend getting in the way of things 😉). Something can be done for both things raised as my quick reply.

-dro
Title: Re: Album Art for Streaming - Module Rename
Post by: MourningStar on February 10, 2019, 05:23:10 PM
I can split / answer the thread properly later tonight (just got that pesky thing of a weekend getting in the way of things 😉). Something can be done for both things raised as my quick reply.

-dro
dro, thank you for checking in, appreciated. Enjoy your time off, it's important for you and this issue is not. I also understand that development of the project should have your priority. All things at your convenience is understood.

ariszlo, Your advice for separate thread for separate issue is logical and I apologize for not doing that.

victhor, thx for chiming in. You too, enjoy your time off.

laters all,
-MourningStar
Title: Re: Album Art for Streaming - Module Rename
Post by: dro on February 11, 2019, 10:50:53 PM
Sorry this was a bit later to reply to (the ATF / Discord emoji issue & irl stuff took longer to do than planned).

Ok, so #1 - that seems a reasonable thing to try & implement as there's no consistent way to get branding artwork from a stream (was tried with SHOUTcast but it flopped really hard). The image you see is the hard-coded default though on the 'album art' preferences page there is a way to override that image if wanted. I've logged this as something to look into as there's a few things I'll need to sort out with artwork & the artwork plug-in to be able to cleanly support it.

For #2 - I've not provided a simple zip version of what is in winamp_res.dll (which is PNG & setup to help me do some core engine overrides more easily) as I didn't think there was any interest for it. As it's the 5.666 files with some wacupification & fixing some visual quirks with the skin. Editing the dll can work but it needs to be the same resource id & type & also format (png) & like was noted that will get replaced when the build gets updated.

Looking over the posts I see it's just not having any text in the titlebar - is that something wanted on all windows or just the main window? As you can just use the image files needed (extract or from the base skin - I'll have to sort out a correctly named copy as I just store things by resource id instead of the winamp core filename expected) & put them in their own folder in the main 'Skins' folder & then select that as the skin.

Any images you don't need to edit will then just fall back to the built-in ones so depending on your needs it could just be main.bmp/main.png (WACUP supports saving & loading the classic skin images as PNG) or it'll normally need a few more for eq, playlist & generic windows but that's not hard to do :)

-dro
Title: Re: Album Art for Streaming - Module Rename
Post by: ariszlo on February 18, 2019, 02:08:45 PM
For #2 - I've not provided a simple zip version of what is in winamp_res.dll (which is PNG & setup to help me do some core engine overrides more easily) as I didn't think there was any interest for it.

MourningStar, have you succeeded in removing the title bar text(s)?
Title: Re: Album Art for Streaming - Module Rename
Post by: MourningStar on February 18, 2019, 04:30:10 PM
^
Located only one image in it that might be the one

No, it is not that. It is this.
I saw that one in there, but did not think it would be the one as it looks all blurry and stuff. So, are you saying if I change this one it will work as desired?
Title: Re: Album Art for Streaming - Module Rename
Post by: dro on February 18, 2019, 04:41:20 PM
Create a folder in the Skins folder, copy the attached file into it & select that folder as the current skin. If you need it to work in a non-WACUP install then it needs to be converted to be a BMP file.

If other windows need it doing then it's simple to do so & I'll be putting up a proper copy of the WACUPified 5.666 base skin later tonight / tomorrow.

-dro
Title: Re: Album Art for Streaming - Module Rename
Post by: MourningStar on February 18, 2019, 05:26:40 PM
Works!

If I modify your png to display "dro's WinAmp" and go thru the steps, it should work too?

I look forward to doing this to the others ...

-thx
Title: Re: Album Art for Streaming - Module Rename
Post by: dro on February 19, 2019, 11:02:05 PM
Yup, that should work.

I've also uploaded the pre-extracted copy of the base skin being used & posted it to https://getwacup.com/community/index.php/topic,517.0.html

You just need to remember that you're limited on the space that you can put text on the titlebars due to the fixed classic skin format & how parts are used to pad out things based on the window size but you should be able to come up with something that fits your needs whether it's winamp or wacup branded. As it's not hard to get back to what the base 5.666 winamp version on the look but you get some of the fixes that were done over the original 5.666 copy.

-dro
Title: Re: Album Art for Streaming - Module Rename
Post by: MourningStar on February 20, 2019, 01:05:09 AM
i am not clear on how to modify other module names (enhancer, classic spectrum analyzer, playlist editor) with that link. I have no clue what a wsz file is ....
Title: Re: Album Art for Streaming - Module Rename
Post by: dro on February 20, 2019, 01:51:09 AM
A wsz is just a renamed zip file (same goes for wal skins which are zipped modern skins but not related to this). Will amend that information in the thread linked above.

It depends what you're wanting to change as I did ask for clarification if it's just blanking the titlebars out on all windows (am happy to do that) or something else but I might have missed that reply.

Enhancer uses it's own image (not in the zip) which I've attached the current copy I've got for it (base.bmp). I should probably try & add in something to the wrapper to maybe auto-use an enhancer.bmp/png if found in the current skin as you otherwise need to manually set it as things currently exist.

CSA uses the generic skinned frame handling so changing that affects everything or then involves modifying the plug-in. As it's titlebar is based on the window text set by the plug-in instead of being predefined in the skin so depending on the requirement determines whether that can be done or not. If it's blanking out titles then that can be achieved by editing gen.png & setting the titlebar filler along with getting the correct part of the text used to fill the titlebar to effectively not look like it's there even though the skin engine will be painting it.

The playlist editor is controlled by pledit.png and works like the titlebar.png example I'd previously posted in just edit a bit of it to get the result needed.

-dro
Title: Re: Album Art for Streaming - Module Rename
Post by: MourningStar on February 20, 2019, 01:59:55 AM
thank you for the attention you have given this dro. However, it all seems out of my league and will withdraw my module rename request. I would rather this effort be spent on the individual album art for 'bookmarked' radio/online streams as per the op. -thx
Title: Re: Album Art for Streaming - Module Rename
Post by: dro on February 20, 2019, 02:06:23 AM
As long as you're sure as depending on what's actually wanting to be set it's not necessarily something I need to be involved with doing (arty people are easier to find around here). Plus since having blanked out the main window title, I'm sort of liking the ambiguity of the titlebar without text so I might still do a version of the base skin that way :)

-dro
Title: Re: Album Art for Streaming - Module Rename
Post by: MourningStar on February 20, 2019, 04:30:17 AM
As long as you're sure as depending on what's actually wanting to be set it's not necessarily something I need to be involved with doing (arty people are easier to find around here). ... -dro
I am not clear as to what you mean here. If you are stating that 'other people' are better suited to implement my stream-based album art request, it does seem they have been  quite silent regarding the matter. However, the night is young ... -thx
Title: Re: Album Art for Streaming - Module Rename
Post by: dro on February 20, 2019, 09:57:02 AM
It was in relation to the skin changes.

-dro
Title: Re: Album Art for Streaming - Module Rename
Post by: MourningStar on February 20, 2019, 04:53:36 PM
It was in relation to the skin changes.

-dro
OK - the term 'skin' is not 100% familiar to me. My  current interpretation of this term is that it refers to the graphic image of each module (enhancer, csa, visualizers, etc.).. Am I close? If I am then modification of these skins is above my skillset. When you provided the modified 'main' skin and the steps to implement,you showed me the 'for dummies' steps and I can do that. I took a stab at the enhancer without success. It seems there are pieces of it thru-out the system. I even learned of a folder labeled 'Virtuastore' that plays a role, as well as folders in app data.

If someone is game, I would like to change 'Classic Spectrum Analyzer' to 'Spectrum Analyzer'.and if a set of 'for dummies' steps (like you provided to me earlier) I will attempt. -thx
Title: Re: Album Art for Streaming - Module Rename
Post by: dro on February 21, 2019, 11:29:18 PM
I'm not sure what you managed to do to end up in the 'Virtuastore' folder as that's not something which is going to be used. For enhancer it's edit the image I'd attached & then the plug-in needs to be instructed to use the edited image file via it's skin browser mode (hence why I need to look to add support to the wrapper to have it try to auto-load an image file from the current skin without the user needing to manually change things).

The CSA window title is defined by the plug-in & would need a newer version of that to get it changed (the alternative option I would suggest doesn't work under WACUP as things stand due to the localisation support being intentionally disabled). Though I'm not 100% keen on changing it unless others prefer the shorter title.

-dro
Title: Re: Album Art for Streaming - Module Rename
Post by: MourningStar on February 22, 2019, 02:57:05 AM
Thank you for the information dro. I would like to drop the module re-name wish entirely and prefer to move forward with the streaming art feature. I can start a new thread, or you can start a new thread or you can modify this one and extract all the module re-name postings.