WACUP

Preview Build Discussion => Preview Build Discussion => Topic started by: 3lectric4ngel on September 12, 2025, 03:40:48 AM

Title: [Bug] Rating cannot be changed
Post by: 3lectric4ngel on September 12, 2025, 03:40:48 AM
When a rating is set for a song (Whether it be via the "View file info" menu or the "Rate items" dropdown menu) the change in rating is reflected in the media library for a split second before "Scanning..." appears in place of the rating, then the rating returns to its previous state.

(Note: I am using the most recent version of x86.)
Title: Re: [Bug] Rating cannot be changed
Post by: dro on September 12, 2025, 11:12:23 AM
What file type(s) are you seeing this with? As I don't see an option to change it with the file info dialog for mp3 files (first thing I checked). It triggering a scanning / local library view refresh probably shouldn't be happening unless there's aspects specific to ratings being actively used in the view whereby it is then correct but doesn't explain it not seeing the new value. My best guess for now is it's reading back in the in-file value instead of keeping the manually set value as saving ratings isn't actively done & tbqh if I could not have to deal with ratings at all I'd remove all of it as I never liked it when I worked on winamp & its one 'compatibility' aspect forced on wacup that I wish I didn't have.
Title: Re: [Bug] Rating cannot be changed
Post by: 3lectric4ngel on September 12, 2025, 11:50:30 AM
It's only happening with FLAC files, I just checked with an MP3 and it works fine.

Admittedly I'm not the biggest fan of the rating system either, but it's a convenient way to have a "favorites" category, so I'd prefer having it over not having it.
Title: Re: [Bug] Rating cannot be changed
Post by: dro on September 12, 2025, 12:58:39 PM
I've made a change related to how the library view will try to reflect the rating change which reduces the chance of a full refresh along with the handling of the metadata might've changed notification which is sent which may help at least some of the problem that you're reporting.