WACUP

Preview Build Discussion => Preview Build Discussion => Resolved Issues => Topic started by: macska on December 24, 2020, 05:10:43 PM

Title: [FIXED] BUG with old winamp2.* skin
Post by: macska on December 24, 2020, 05:10:43 PM

Hi ! I am using latest preview version, fresh install..using oldschool skin. on windows10pro. When pressing the stop button or any other button, nothing happening.. only 2nd pressing...there is a little video..sry for my english..

https://imgur.com/a/tQW5aH7 (https://imgur.com/a/tQW5aH7)

Title: Re: BUG with old winamp2.* skin
Post by: Eris Lund on December 24, 2020, 05:17:43 PM

I personally can't see it with anything I try, what exactly were you playing? (MP3, FLAC, etc)

Title: Re: BUG with old winamp2.* skin
Post by: dro on December 24, 2020, 05:19:25 PM

It's because of toggling from windowshade mode to normal mode & there was a temporary workaround added (until I take over the main window drawing from the Winamp core) in the recent build that tries to filter out that toggle action being able to trigger the action buttons (play / pause / etc) due to where the mouse is seen as being whilst the classic main window is being resized.

I'll see about getting that workaround improved for the next update though the sooner I drop the need for the Winamp core the better. At least it didn't crash as that was also part of the reason for needing to add in the workaround for a bug in Winamp's core :)

-dro

Title: Re: BUG with old winamp2.* skin
Post by: macska on December 25, 2020, 04:03:00 AM

Quote from: Gordon Freeman on December 24, 2020, 05:17:43 PM

I personally can't see it with anything I try, what exactly were you playing? (MP3, FLAC, etc)

Tested on mp3 and flac too..
Deleted *.* reinstalled again..no options..nothing changed..play the first flac, or mp3 and same problem..
Thanks for Wacup !!!

Title: Re: BUG with old winamp2.* skin
Post by: dro on December 29, 2020, 03:54:25 AM

I've now properly had a look into this & the position of the mouse when having the main window docked to the top of the screen makes it easier to replicate.

The problem was the temp fix I'd put in place isn't correctly dealing with the classic main window expanding down instead of the issue that led to need to fix with the window expanding upward when docked to other windows.

I've got a change for the next build but like I noted earlier, I've got to take over the complete main window handling to properly resolve this.

-dro

Title: Re: BUG with old winamp2.* skin
Post by: macska on December 31, 2020, 01:48:45 PM

Problem solved.. Thank You Very much !!! Wacup is the best !!!..with old winamp skin :):) Happy new year !!!

Title: Re: [FIXED] BUG with old winamp2.* skin
Post by: dro on December 31, 2020, 03:05:32 PM

Thanks for the quick confirmation & a happy new year to you as well.

-dro