"the visualisation plug-in executed illegal operation."

[carls.haven]

hello everybody!

first off, big thanks to Dr.O, amazing work!

however, i am having issues with a _3rd_party_ visualisation plug in, _not_ a built in one.
how to replicate;
install JavaRE 32bit, at least 7u151
install winamp v2; yes i know its not WaCup, but its needed for further steps.
download Morphyre Personal at https://www.morphyre.com/Download note its _not_ the Pro version.
when installing MP, make sure the winamp plugin is checked.
once installed, you can run MP through either the start menu or through winamp2
in winamp2, copy vis_Morphyre.dll into WaCup\Plugins
in WaCup, try to run Morphyre.
i somehow did get it to work in single visualisation mode twice, but now i can't get that. multi-visualisation always crashes;
The visualisation plug-in executed illegal operation. A restart is reccomended (1)
in previous WaCup 1.0.21.7236 it does work, but build 20202 just does not like it i guess.

any help? TIA

[dro]

I'll have a look once I resume development later this month. I can't think of anything obvious as to why it'd be misbehaving if it had been ok with the almost 4 year old build as not much has been done when it comes to vis handling. As for multi-vis some plug-ins just won't behave as they were never meant for such things especially if trying to run under a modern style skin.

[carls.haven]

certainly, no rush, please take your time, and thank you!
as for the skin, i just use the basic classic skin, as i personally find its legibility to be better then the others. as for multi-vis, that is how i run it without issue in 7236. the option to run multiple vis plugins simultaneously is awesome! definitely staying on x86 builds specifically for that alone lol. i should have also noted that i haven't specifically tried it with the versions between 7236 and 20202, but will if requested as i have a few installers saved.
edit; works as multi in WACUP_Preview_v1_99_16_19516, so its just the latest preview that it fails in. edit-edit; now its failing in 19516, so i don't know what is happening 
edit3; WaCup is complaining about dlls that are present, and just sent a crash report from 19516, so hopefully that sheds some light on something. again, in your own time, i'm just adding info here to keep it in one place.

[dro]

I'd not seen the edits & luckily hadn't purged the legacy crash reports from the older builds that I do periodically though the crash didn't seem to show me much other than morphyre was trying to call something no longer there when process close was happening.

With the crash on loading, I made a change for the x64 build just before 19516 was created with how the embedded window frames are able to be created by plug-in as Morphyre uses & it messed up an expectation of how that works for the x86 plug-ins. I've now changed that back & its loading ok again. I've also fixed it to use the correctly scaled window frame so it'll match the look of the classic skin scaling.

However I'm still seeing it intermittently prevent WACUP from closing normally when the plug-in is running so I've got to look into that.

[dro]

However I'm still seeing it intermittently prevent WACUP from closing normally when the plug-in is running so I've got to look into that.

I've possibly found something that'll better allow the process to close irrespective of plug-in / external dll weirdness messing up things from what I could see with this plug-in so hopefully the next build will be better behaved on all counts.

[carls.haven]

all fantastic news, massive thank you! whenever the next preview is out (no rush, take your time) i will update, and post what happens in this thread.
happy holidays!