WACUP

General => Wishlist / Feature Requests => Topic started by: Benco on November 12, 2017, 10:09:52 PM

Title: Art Navigator
Post by: Benco on November 12, 2017, 10:09:52 PM
Hi DrO,

first, I'm not sure you got my message about beta testing. I can't see it in my message box...

My idea is close to the ultimate "playing now" I've already seen on this forum. What about having a way to navigate through all the art embedded  in a file, not only the cover ? I like to have, when possible, all the scans from an album (Qobuz, for example, often provides it), but in Winamp, I can only enjoy the cover. WHat about a plugin that, when double clicking on the cover art , opens an art navigator in which one could swipe from one image to the others. Even better, have all the images arranged depending on their tag, with the box and the inner book (not sure I'm clear enough...)

Anyway, thanks for the great work!
Title: Re: Art Navigator
Post by: dro on November 12, 2017, 10:45:11 PM
If you've sent a PM then it'll start being actioned tomorrow 13th (monday) now that a new build is available I'm working on the backlog of requests.

At the moment 'cover' is all that's done as that's just what the Winamp native behaviour is setup to work with. To support other artwork types (front, back, etc) needs the Winamp UI for handling artwork to be changed & for the relevant plug-ins to be updated (or a shim put in front of them to support it until a replacement plug-in is made e.g. with in_mp3). So doing all of that (which would be more like mp3tag from my experience) is probably going to go a long way towards what you're wanting.

Having a view mode to see what's there (other than via the tagging interface), that's potentially a bit trickier due to only a 'cover' assumption (e.g. modern skins might be hard to get working). Though for classic skins or via a custom plug-in / UI element then I don't see why something couldn't be done (e.g. left/right in the album art plug-ins window could move through the available artwork types). There'd probably also need to be some preference option to determine the read order of the artwork so if needed something else could be the default instead of 'cover' if found (or just how to proceed if a type is missing).

-dro
Title: Re: Art Navigator
Post by: Benco on November 13, 2017, 07:47:20 PM
I'l not sure what you mean in your first paragraph. Do you talk about art editing? Because I only mean visualization.
About that, I'm personally more interested in a modern UI solution, since I use Bento, but I understand the difficulty of it. Maybe a new tab in the media library?
There maybe another solution, but I guess it's more skin-specific : an option could be added to Bento for having all the art displayed in the multi-content view area.
Title: Re: Art Navigator
Post by: dro on November 13, 2017, 08:07:08 PM
Ok, we might have gotten our wires a bit crossed on what's actually being wanted (though it still requires underlying changes made to allow for plug-ins / skins to have the potential to access any of the artwork types that can exist in a tag other than just the 'cover' type). I was referring to viewing & editing but more within the confines of an editing scenario rather than (as I think might now be the case) in showing all of the artwork types at the same time in a view.

Whatever might be done, I hold to it needing to work in any skin type & not just modern skins (which was how it was done officially for a long time to the detriment of classic skin users imho when changes could be made to achieve feature parity). Will have a think about this as it'd probably be more suited in some form for a post v1.0 release.

-dro
Title: Re: Art Navigator
Post by: Benco on November 13, 2017, 09:15:17 PM
I understand the need for features to work with both type of skins. Maybe the media library tab is the best solution for maximum skin compatibility (even though my preference would go to multi-content view).
Title: Re: Art Navigator
Post by: dro on November 13, 2017, 09:30:50 PM
Relying on the library isn't always a safe assumption either as a lot of people don't like it & won't have it installed (something else I'm trying to do with WACUP is remove the need for the library to be able to still achieve certain functionality like skinning & the send-to menu).

The main down-side with the multi-content view is that it's a very skin specific implementation (i.e. Bento was coded specifically to provide that mode). I get that a lot of people don't bother changing the skin (based on how many I came across over the years despite an option during setup that didn't realise the skin could be changed).

When I'm in a position, then I will hopefully be able to come up with a solution that meets your needs & the other thoughts that it's spawned in my head :)

-dro
Title: Re: Art Navigator
Post by: victhor on November 13, 2017, 11:29:20 PM
@Benco: I think there is already something quite like what you want on Winamp >> https://web.archive.org/web/20170411134247/http://www.skinconsortium.com/index.php?page=ViewDownload&itemID=126
But as you can see, it's heavily relying on a "skin-system"; you have to install Classic Pro, and then the plugin itself.

In case you're interested on testing it and see how much it meets your requirements, let me know and I can hand you over the latest installers. Right now the Skin Consortium's page is down so there is little to no access to their stuff =(, though I'm confident someone is working (or is about to..) on the site to get it back on track.
Title: Re: Art Navigator
Post by: Benco on November 18, 2017, 11:58:13 AM
@victhor : thanks, I'm interested in testing this plugin, could you provide me a link ?
Title: Re: Art Navigator
Post by: Pawel on November 18, 2017, 03:38:28 PM
I wrote installer for ClassicPro. So, I do have all stuff :P

Here is a widget you are asking: http://www.meggamusic.co.uk/shup/1511019443/cpro-widget-Picturebox-0.93.exe
-Pawel
Title: Re: Art Navigator
Post by: victhor on November 18, 2017, 05:27:11 PM
I wrote installer for ClassicPro. So, I do have all stuff :P

What? How's that? Do you have an installer for the latest beta? (IIRC 2.03 April 2017)
Title: Re: Art Navigator
Post by: Pawel on November 18, 2017, 10:57:59 PM
I am sure I don't have the latest one (Version 2.02 (1 September 2013))
I wrote installer, but it was long time ago. Since that time Martin made some changes if I remember.
For sure, he has got the latest sources...
-Pawel
Title: Re: Art Navigator
Post by: dro on November 18, 2017, 11:13:55 PM
Bit confused on the last few posts as it seems to be talking about cPro and the last version released is included with WACUP and 1001skins has a copy off it. Unless I'm not following what's being talked about...

-dro
Title: Re: Art Navigator
Post by: victhor on November 18, 2017, 11:36:47 PM
.cPro and the last version released is included with WACUP and 1001skins has a copy off it..

You're right! Haha.. I just don't get used to it.
Title: Re: Art Navigator
Post by: Pawel on November 19, 2017, 10:37:59 AM
Bit confused on the last few posts as it seems to be talking about cPro and the last version released is included with WACUP and 1001skins has a copy off it. Unless I'm not following what's being talked about...

-dro

Yes, I know you distribute CPro with WACUP :)
But if I am not wrong, you don't distribute all widgets (only BrowserPro, NowPlaying).
@Benco asked about widget (suggested by @victhor) and I have it on my disk (svn copy for 2.02 version) -> Chapterlist, CoolVU, PictureBox,  Shoutbox.
-Pawel

Ps:
CPro in WACUP:
1. You distribute source m files, but I do not see maki compiler...
2. This looks like unpacked installer dir (via 7zip -> to remove?): WACUP\Plugins\ClassicPro\engine\widgets\Data\NowPlaying\$SMPROGRAMS
3. This also should be removed, as this includes installes source files (NOT INCLUDED): WACUP\Plugins\ClassicPro\engine\widgets\cpro-widget-BrowserPro.nsi


Title: Re: Art Navigator
Post by: Aminifu on November 19, 2017, 04:34:39 PM
The BrowserPro and NowPllaying widgets are the only ones included in the official installer provided by cPro's developer. WACUP only provides what the official cPro installer does. Yes, there are other widgets that are not included. It's like plug-ins with Winamp/WACUP. There are a great deal more plug-ins available than what are in the official installers.

My point is that developers may provide some support for what is in their official installers, but can not be expected to provide support for what is not.
Title: Re: Art Navigator
Post by: dro on November 19, 2017, 05:31:41 PM
But if I am not wrong, you don't distribute all widgets (only BrowserPro, NowPlaying)
My aim was only to include the _base_ cPro files needed & not the additional widgets as they're not required to use a cPro skin.

@Benco asked about widget (suggested by @victhor) and I have it on my disk (svn copy for 2.02 version) -> Chapterlist, CoolVU, PictureBox,  Shoutbox.
This is why I was looking for some clarification of what was actually being talked about / wanted as it wasn't 100% clear :)

Ps:
CPro in WACUP:
1. You distribute source m files, but I do not see maki compiler...
2. This looks like unpacked installer dir (via 7zip -> to remove?): WACUP\Plugins\ClassicPro\engine\widgets\Data\NowPlaying\$SMPROGRAMS
3. This also should be removed, as this includes installes source files (NOT INCLUDED): WACUP\Plugins\ClassicPro\engine\widgets\cpro-widget-BrowserPro.nsi
What I included in WACUP is what was provided in the last installer provided (the 2.03 revision) & effectively just is a folder copy since that worked & not knowing the full details of what is / isn't needed, it was simpler to go that route (since that's what was being 'officially' provided.

Afaik all of the maki files are there (based on what I've taken from the installer I was working with vs what got installed by said installer). I'll remove those parts you've mentioned though it may only apply to new installs as I try not to touch that folder unless there's a proper new update that needs to be installed (which seems like there may not be any going forward with the demise of the site & other things).

-dro
Title: Re: Art Navigator
Post by: dro on November 19, 2017, 05:37:11 PM
My point is that developers may provide some support for what is in their official installers, but can not be expected to provide support for what is not.
Well said :) Like I put in my reply above, I'm only including what was officially provided just for that reason, including everything adds a level of expected support when it cannot really be achieved.

As I could have done as some have proposed elsewhere & just bundle every known plug-in into a plug-in pack & that be wacup but that would just not be a nice experience (once you filter out the ones that crash on loading) as including everything obtains the 'bloat' complaints but then not including enough gets complaints from those who just cannot be bothered to install something else.

So I'd like to think in the cPro scenario that I've got a reasonable middle-ground in using just the 'base' install & if more is wanted then the user (as was always the case) then they can be manually installed (but that brings the issue in finding them if the original site is gone at this time).

-dro
Title: Re: Art Navigator
Post by: Benco on November 25, 2017, 02:43:27 PM
Hi all,

thanks for the link. This picture box widget gets the job done. On the other hand, it's even more restrictive than just relying on modern skins. I prefer to use the Big Bento skin, and couldn't find an exact CPro copy of it (though there's one that is quite close to it).
Title: Re: Art Navigator
Post by: dro on November 27, 2017, 05:50:16 PM
I've finally gotten around to trying out the picturebox widget & it seems to be failing to find / show the artwork in most of the files I had in my test install. Maybe I'm missing something but for the ones that it does show something, what it shows doesn't seem correct as I know there's no folder.jpg or albumartsmall.jpg files. However looking at it, it makes it clearer of what's being asked for :)

-dro
Title: Re: Art Navigator
Post by: victhor on November 28, 2017, 02:21:02 AM
I've finally gotten around to trying out the picturebox widget & it seems to be failing to find / show the artwork in most of the files I had in my test install. Maybe I'm missing something but for the ones that it does show something, what it shows doesn't seem correct as I know there's no folder.jpg or albumartsmall.jpg files. However looking at it, it makes it clearer of what's being asked for :)


Hmm.. it's working for me on last WACUP build, the screenshot shows how JPGs and PNGs are displayed, but what you won't get is the embeded mp3 cover (also seen on the screenshot). The widget is easy to mod (I changed some stuff the last time I used it, don't remember what but I do remember it was easy), so it can be probably tweaked to show embeded as well.
Title: Re: Art Navigator
Post by: dro on November 28, 2017, 02:40:20 AM
The files I tried usually only have embedded artwork (they're mainly podcasts) so I might need to re-check what's going on with the ones that worked (as I did look for image files in the folder & there weren't any).

As I would have thought getting the embedded would work due to the rest of the skin engine being but looking at the code for the widget, it only seems to be looking for physical image files (based on what readImages() looks to me).

Either way, I know what I need to do for a skin independent solution :)

-dro
Title: Re: Art Navigator
Post by: Benco on December 08, 2017, 12:51:43 AM
Hi DrO,

do you think the solution you have in mind could be incorporated in single window modern skins too ? I mean, without having a specific window for it ?
Title: Re: Art Navigator
Post by: dro on December 08, 2017, 03:16:43 AM
What I'm thinking would be done as part of the album art plug-in which works in all skins but as it's own window. Having that window integrated into a modern skin would then require skin modifications (though some modern skins may automatically do it as a tab within the skin - which may be fine for you). Though I think like I've mentioned before, artwork within Winamp/WACUP just needs a complete overhaul in how it can be accessed (but I don't think it'll be part of WACUP v1.0).

-dro
Title: Re: Art Navigator
Post by: Aminifu on December 08, 2017, 03:43:29 AM
I've finally gotten around to trying out the picturebox widget & it seems to be failing to find / show the artwork in most of the files I had in my test install. Maybe I'm missing something but for the ones that it does show something, what it shows doesn't seem correct as I know there's no folder.jpg or albumartsmall.jpg files. However looking at it, it makes it clearer of what's being asked for :)

-dro

From time to time, the Windows OS uses the Windows Media Player to create hidden folder.jpg and albumartsmall.jpg files in various music file folders. Often additional hidden images with other names are also created. Enable the folder viewing option to show hidden system files in Windows Explorer, you may be surprised by what you find. This has been discussed in the Winamp forums and nobody knows what triggers the OS to do this.

When it happens to me, I just delete these hidden images. Sometimes they come back after awhile, so I routinely check for them from time to time.
Title: Re: Art Navigator
Post by: dro on December 08, 2017, 04:19:46 AM
I have hidden / system files enabled as one of the first things when I make a windows install :)

That's why I was confused but what the cpro widget is showing for me for some of my files as there aren't any of those files within the folders (which I also checked via the alt+3 dialog & what the albumart service reports back on what it was able to find as the origin of the source). Though I didn't dig much into the widget's source code to what & where it is actually looking for things (the quick look showed it's not using the albumart service).

-dro
Title: Re: Art Navigator
Post by: Aminifu on December 08, 2017, 07:04:53 PM
I have hidden / system files enabled as one of the first things when I make a windows install :)
...

Seeing the system files on the desktop is distracting for me, so I normally keep that option disabled.  ;)

The additional image files I discover from time to time in my music folders are different resolutions of the same images. When you get the time to explore the widget further, it would be good to know where it is finding these folder.jpg and albumartsmall.jpg files.

Windows annoying habit of randomly overwriting folder.jpg files is 1 of the reasons why I stopped using them in Winamp and started using embedded images for all of my music files that I play with Winamp/WACUP. At some point down the road, it would be great to be able to embed more than 1 image per file and be able to cycle thru them.