Anyway to fix this two skins?

[Matsuriko]

Hi, im new sorry if is the wrong place to ask. I recently came to wacup after many years of using the old 5.666 and everything is working fine except for the main 2 skins i generally use. They are two Vocaloid modern skins, one of them makes all context menu white with text white so is unreadable, the other skins is just broken, every other box is just broken.

Anyway to fix them?

Edit: Added final fixed version together with the original files without changes in one zip file, and a newer version of one of the skins that i just found out in a lost facebook post.

[ariszlo]

For the first one:

1. Unzip Vocaloid 001.zip
2. Open Vocaloid 001\xml\system-colors.xml with Notepad.
3. Find this: <color id="wasabi.window.text" value="255,255,255"/>
4. Change the value from "255,255,255" to "0,0,0" and save the file.

For the second one:

1. Unzip Vocaloid 002.zip
2. Open Vocaloid 002\xml\standardframe.xml with Notepad.
3. Remove the following two lines and save the file:
<layer id="regionleft"  x="0"  y="31" w="192" h="-34" relath="1"  image="component.region.left"  sysregion="-2"/>
<layer id="regionbottommiddle" x="192"  y="-34" w="-223" h="34" relaty="1" relatw="1" image="component.region.bottom.middle" sysregion="-2"/>

[dro]

I've yet to try the modifications mentioned above (am sure they're all good) but I'm seeing the menu issue with Vocaloid 001 also under 5.666 so that doesn't appear to be a wacup introduced issue which'd match to the suggested edit to the skin.

With Vocaloid 002, that is wacup specific as part of how I've gotten 5.666's gen_ff plug-in working outside of winamp. Based on what's shown in the screenshot along with ariszlo's suggestion it'll be down to something with how I handle regions being wrong or its exposed something the skin was doing wrong.

Alas I was hoping that a fix I've got coming up for cpro skins & how layers without images are dealt with might've helped with this issue but it doesn't seem to from a quick test of the skin. Will add this to things to check out but for now would go with modifying the copy of the skin as the best way to get things fixed until I can look into the problem in my code.

-dro

[Matsuriko]

Yeap, both changes are working perfectly.

About Vocaloid 001, maybe i had an older version because i dont remember having that problem, but is solved. I will keep a copy of Vocaloid 002 with the changes sugested, they look to be working fine.

In case anyone is interested below in the first post, are the skins with the changes, i should mention that vocaloid 001 i added sometime in the past a notifier, that is not original to the skin, aditionally now i have updated vocaloid 002 notifier with the one from 001 because it wasen't working correctly (the original from 002 just stayed there without closing).

Thanks for the explanations and the fixes for the skins, and all the work on WACUP

[ariszlo]

I'm seeing the menu issue with Vocaloid 001 also under 5.666 so that doesn't appear to be a wacup introduced issue...

Yes, the menus of many skins got messed up with the skinned menus, re-introduced in Winamp 5.666, if the value for the wasabi.window.text colour definition was the same as or very similar to the window background colour.

With Vocaloid 002, that is wacup specific as part of how I've gotten 5.666's gen_ff plug-in working outside of winamp. Based on what's shown in the screenshot along with ariszlo's suggestion it'll be down to something with how I handle regions being wrong or its exposed something the skin was doing wrong.

The bug seems to be caused by completely transparent regions bitmaps. WACUP handles the regions well if the bitmap contains both opaque regions marking the window areas that should NOT be shown and transparent regions marking the window areas that should be left alone.

The skinner of Vocaloid 002 defined two completely transparent regions bitmaps, which is just a waste of code that should be simply ignored. It seems that WACUP wrongly interprets an all-transparent bitmap as if it was an all-opaque bitmap.

i should mention that vocaloid 001 i added sometime in the past a notifier, that is not original to the skin, aditionally now i have updated vocaloid 002 notifier with the one from 001 because it wasen't working correctly (the original from 002 just stayed there without closing).

Good job with the notifiers. 

[dro]

I'm seeing the menu issue with Vocaloid 001 also under 5.666 so that doesn't appear to be a wacup introduced issue...

Yes, the menus of many skins got messed up with the skinned menus, re-introduced in Winamp 5.666, if the value for the wasabi.window.text colour definition was the same as or very similar to the window background colour.

That's entirely down to the skinners imho. Enabling skinned menus by default was to try to make the ui more consistent within itself vs what was seemingly coming in with Windows menus vs the skinned look being at odds. So I'm going to disagree that enabling it messed things up as it can only ever go with the information that skins provide to it.

Could / should more be more done to try to avoid it yes & from a wacup stance where I've still to implement trying to read in the modern skin menu values it's going to have to wait until that for something to be attempted to try to force enough distance between the text vs background colouring (which'll be more likely to then mess things up for skins that otherwise need to be updated).

-dro

[ariszlo]

So I'm going to disagree that enabling it messed things up as it can only ever go with the information that skins provide to it.

Sorry, I did not express myself properly. The skins whose window text colour is very similar to the window background colour had already been messed up long before Winamp 5.666 re-added skinned menus. One could not see "Search" before the search box or the info at the bottom of the media library displaying "n items (HH:MM:SS) in n sec".

Winamp 5.666 only made it more visible how messed up those skins were. So, the two of us do not really disagree.

[dro]

Winamp 5.666 only made it more visible how messed up those skins were. So, the two of us do not really disagree.

Is all good & yes I agree with that & in hindsight the intent of that change like so many things was rushed in trying to do what seemed to make sense when probably it'd have been better to leave it alone but that's hindsight for you.

-dro

[Matsuriko]

I wanted to ask another small thing that i just noticed recently unrelated to wacup itself but with the notifier in the skin, and was looking for information online when i noticed that Ariszlo was the one who uploaded the notifier replacent, so im just going to ask here hope its not a problem.

Does the notifier have any problems with fonts?
Cant remember a this moment (nor i have the version i was using before to check in this moment) if it was working in old winamp, but with wacup, is not showing japanese characters even tho wacup can show them, both with the default font of the notifier (ariel) and the font from the old notifier (ms gothic), maybe im just doing somenthing wrong?

[ariszlo]

Raise the value of WasabiXML version to 1.3 1.36 in skin.xml

[Matsuriko]

i swear, every fix that i do, somenthing even smaller appears, the fix works but it breaks this little thing on both skins (the scroll thing in the playlist), now this is super small so its not important but maybe its also easy to fix? (the never ending fixing of this skins damm)

[dro]

The 1.3+ value causes a different style of scrollbar to be assumed to be present in my code since the skins that were created against that spec had the 'freeform' scrollbar support image elements but if the skin hasn't been altered to offer what's needed then it'll act up / use a fallback. It's like you're taking a web page from the 00s & just saying use the current day web specs where it often will be ok but there's likely going to be some differences that have crept in over that time. Am sure ariszlo can point you on what needs to be added to get it closer to what you're used to.

-dro

[ariszlo]

the fix works but it breaks this little thing on both skins (the scroll thing in the playlist), now this is super small so its not important but maybe its also easy to fix?

It's not possible to change the size of the scrollbars in WasabiXML v1.3x skins, only their colours. This is how you can do that for MSDZero skin:

1. Copy the attached scrollbars.png into the window folder of the skin.
2. Remove all the studio.scrollbar.* definitions from system-elements.xml.
3. Paste the following wasabi.scrollbar.* definitions into system-elements.xml:

<bitmap id="wasabi.scrollbar.vertical.left" file="window/scrollbars.png" x="0" y="0" w="13" h="17"/>
<bitmap id="wasabi.scrollbar.vertical.left.hover" file="window/scrollbars.png" x="14" y="0" w="13" h="17"/>
<bitmap id="wasabi.scrollbar.vertical.left.pressed" file="window/scrollbars.png" x="28" y="0" w="13" h="17"/>

<bitmap id="wasabi.scrollbar.vertical.button" file="window/scrollbars.png" x="0" y="18" w="13" h="41"/>
<bitmap id="wasabi.scrollbar.vertical.button.hover" file="window/scrollbars.png" x="14" y="18" w="13" h="41"/>
<bitmap id="wasabi.scrollbar.vertical.button.pressed" file="window/scrollbars.png" x="28" y="18" w="13" h="41"/>

<bitmap id="wasabi.scrollbar.vertical.right" file="window/scrollbars.png" x="0" y="60" w="13" h="17"/>
<bitmap id="wasabi.scrollbar.vertical.right.hover" file="window/scrollbars.png" x="14" y="60" w="13" h="17"/>
<bitmap id="wasabi.scrollbar.vertical.right.pressed" file="window/scrollbars.png" x="28" y="60" w="13" h="17"/>

<bitmap id="wasabi.scrollbar.horizontal.left" file="window/scrollbars.png" x="42" y="0" w="17" h="13"/>
<bitmap id="wasabi.scrollbar.horizontal.left.hover" file="window/scrollbars.png" x="42" y="14" w="17" h="13"/>
<bitmap id="wasabi.scrollbar.horizontal.left.pressed" file="window/scrollbars.png" x="42" y="28" w="17" h="13"/>

<bitmap id="wasabi.scrollbar.horizontal.button" file="window/scrollbars.png" x="60" y="0" w="41" h="13"/>
<bitmap id="wasabi.scrollbar.horizontal.button.hover" file="window/scrollbars.png" x="60" y="14" w="41" h="13"/>
<bitmap id="wasabi.scrollbar.horizontal.button.pressed" file="window/scrollbars.png" x="60" y="28" w="41" h="13"/>

<bitmap id="wasabi.scrollbar.horizontal.right" file="window/scrollbars.png" x="102" y="0" w="17" h="13"/>
<bitmap id="wasabi.scrollbar.horizontal.right.hover" file="window/scrollbars.png" x="102" y="14" w="17" h="13"/>
<bitmap id="wasabi.scrollbar.horizontal.right.pressed" file="window/scrollbars.png" x="102" y="28" w="17" h="13"/>

<bitmap id="wasabi.scrollbar.horizontal.background" file="window/scrollbars.png" x="42" y="42" w="13" h="13"/>
<bitmap id="wasabi.scrollbar.horizontal.background.top" file="window/scrollbars.png" x="42" y="42" w="13" h="13"/>
<bitmap id="wasabi.scrollbar.horizontal.background.middle" file="window/scrollbars.png" x="42" y="42" w="13" h="13"/>
<bitmap id="wasabi.scrollbar.horizontal.background.bottom" file="window/scrollbars.png" x="42" y="42" w="13" h="13"/>

<bitmap id="wasabi.scrollbar.vertical.background" file="window/scrollbars.png" x="56" y="42" w="13" h="13"/>
<bitmap id="wasabi.scrollbar.vertical.background.top" file="window/scrollbars.png" x="56" y="42" w="13" h="13"/>
<bitmap id="wasabi.scrollbar.vertical.background.middle" file="window/scrollbars.png" x="56" y="42" w="13" h="13"/>
<bitmap id="wasabi.scrollbar.vertical.background.bottom" file="window/scrollbars.png" x="56" y="42" w="13" h="13"/>


 

[ariszlo]

And this is for the SaNari-Metallica skin.

[Eris Lund]

Hang on, it is possible to change the size of Wasabi scrollbars.
You're not bound to any sort of limits here, you just can't change the Classic Skin-type scrollbars size wise