Recent Posts

1

General Discussion / Re: Drag and drop a music folder with a playlist file adds duplicate files

« Last post by Master on November 27, 2023, 02:25:44 PM »

Thanks again for your reply, this was just an annoyance I encountered while using WACUP for the first time. I thought maybe it was some kind of setting but maybe it was not.

The strange thing is when I choose "Add folder" from the "playlist editor" it DOES filter out dupes and only adds a file  once when it contains mp3+m3u. Maybe some code could be reused there.

2

General Discussion / Re: Drag and drop a music folder with a playlist file adds duplicate files

« Last post by dro on November 24, 2023, 11:01:16 AM »

I get what you're describing, I just don't remember it as being a thing Winamp would do from having previously worked on it to ignore playlists found within drag+drop actions though I see 5.666 acting as described from a quick re-test so I guess my memory of things isn't all that great nowadays. Maybe I need to consider adding in an option to ignore playlist files on drag+drop actions.

De-duplicating what WACUP adds from drag+drop actions along with trying to use the playlist ordering &/or metadata to get the expected track order to deal with Explorer not often providing files in the expected order (due to file creation, selection quirks in Explorer) is something already on my list of things to do. So doing all of that might be the more sensible thing to do with my time vs an option that imho could cause more issues than it helps, will have to have a think & see when I can schedule it into things.

-dro

3

General Discussion / Re: Drag and drop a music folder with a playlist file adds duplicate files

« Last post by Master on November 24, 2023, 05:39:35 AM »

Hi, thanks for your quick reply.

In Winamp 5.666 it works fine. It looks like they do some kind of duplicate file check when drag-and-dropping from file explorer.

I've added a video to make it more clear what I mean.

4

General Discussion / Re: Drag and drop a music folder with a playlist file adds duplicate files

« Last post by dro on November 24, 2023, 01:31:35 AM »

No such option currently exists & a smarter handling of drag+drop still needs to be coded so for now it'll just add what it's given even if that then duplicates things. I'm also not aware of Winamp having done any filtering of things either since both programs just parse the given list of files from the drag+drop action.

-dro

5

General Discussion / Drag and drop a music folder with a playlist file adds duplicate files

« Last post by Master on November 24, 2023, 01:01:33 AM »

Hi quick question:

When I drag and drop a folder (with mp3 files and a m3u playlist) to the playlist editor it always adds all files twice, it adds both the mp3s AND all the files inside the m3u playlist (the same) it seems. Old Winamp somehow filtered the dupe files when drag and dropping. I cant seem to find any WACUP setting for this unfortunately.

Can anyone help me out? Thanks in advance.

Version 1.9.20.17040
OS Win 10

6

Preview Build Discussion / Re: Media Library refresh should be more clever

« Last post by dro on November 20, 2023, 03:22:20 PM »

Without trying it out I'm not sure but it's something I've got on my of things to consider once I can be certain of the core input plug-ins being able to cope with it. The folder monitor handling is itself multi-threaded so it checks for files to consider & then hands that over to a different thread which then does the metadata reading allowing for the initial scan to generally take less time. That's still hitting multiple files on the drive at the same time due to the overlapping of things relying somewhat on the OS / file system cache to minimise the effect of it.

-dro

7

Preview Build Discussion / Re: Media Library refresh should be more clever

« Last post by Aminifu on November 20, 2023, 03:01:42 PM »

...

So even if it only takes a few milliseconds per file (which isn't bad), that over 250k of files is going to easily be in the 12-15min range & I have been debating making ml_ll look at 2 files at a time instead of just 1 which could reduce the overall time but it could be slower depending on the drive contention & how well the input plug-ins deal with multi-threaded access (there's some that don't like it at all).

-dro

Just my 2 cents. It seems that trying to look at 2 files at a time is not worth the effort. The folder monitor is great for quickly picking up a few changes in a large database. The in-dept refresh is also useful at times, even if/when it takes awhile to finish.

8

Preview Build Discussion / Re: Media Library refresh should be more clever

« Last post by dro on November 20, 2023, 01:42:57 PM »

I think I see what the some of the confusion is now I've had a look back at what the ml_local options were.

The ml_ll refresh option is intentionally set to re-read the files because the modified file time can't always be relied upon as there's tools that don't always modify it whereas ml_local offers a differently named option that is a trigger option for its watch folders feature which afaict would just look for overall file differences (time changed / not present).

I will look to add an equivalent folder monitor trigger to ml_ll's library button sub-menu though I'm likely going to do it so specific folder monitor entries can be triggered for those that are enabled at the time or something along those lines (will see what happens when I start coding things).


The ml_ll folder monitor is equivalent to ml_local's watch folder handling & it should be importing the folder list from ml_local's settings though the comment about it being enabled by default, I'm not sure what's meant by that. As the prefs is always going to be there & the logic is if it's present in the imported settings then any folders should be auto-enabled on an ~6hr default interval between scans vs any other config options such as how it's done on initial loading (as unlike ml_local I try to avoid it spinning up too soon if doing quick load & close / post-crash issues).

There's even an option on the import folder dialog which allows for them to be added to the folder monitor but that isn't enabled by default because I've seen too many cases of sub-folders being added which'd then cause the folder monitor to be looking at many folders when it's not appropriate - maybe that's what is being referred to as not enabled by default ?


One final thing, ml_ll's metadata reading is more involved than ml_local's since it collects more information about the files such as format information & associated albumart which obviously can take longer to determine per file despite doing what is reasonable to try to minimise how long it overall takes to do all of that.

So even if it only takes a few milliseconds per file (which isn't bad), that over 250k of files is going to easily be in the 12-15min range & I have been debating making ml_ll look at 2 files at a time instead of just 1 which could reduce the overall time but it could be slower depending on the drive contention & how well the input plug-ins deal with multi-threaded access (there's some that don't like it at all).

-dro

9

Preview Build Discussion / Re: Media Library refresh should be more clever

« Last post by Aminifu on November 20, 2023, 04:34:32 AM »

Yeah, great!  IIRC, that feature did have a few issues when it was first introduced and I think it is disabled by default, which I had forgotten.

WACUP does have a lot of options. I force myself to look at all the preferences with every new release. Every now and then something useful pops up. It's also a good idea to take the time to carefully read the changelogs.

10

Preview Build Discussion / Re: Media Library refresh should be more clever

« Last post by jim2005 on November 19, 2023, 11:09:50 AM »

The recent beta releases have a feature in the preferences media library group called folder monitor that does what you're asking for. I don't know if it is also in the current public release. Look for it.

I checked it and it, happily, exists in the preview build too. It was disabled in my installation. Is it (i.e. disabled) the default setting? If yes, I think it should be changed since it's an easily overlooked option.

Now that I have enable it, WACUp detects folder structure and metadata changes (like lyrics).
Many thanks!