Messages

16

Resolved Issues / Re: cant open internet radio

« on: September 25, 2024, 09:38:04 AM »

My guess as I don't know what your media library window (or the embedded area in the skin being used) looks like has had its navigation tree panel put all the way to the left of the window which would then hide it. There should be a vertical divider by the left edge of the media library window if that's happened which can either be click & dragged to the right or double-click on the divider for it to try to resize itself to the contents of the navigation tree. Otherwise a screenshot of your running wacup instance would be needed to try to figure it out.

-dro

17

Preview Build Discussion / Re: Song Ratings not displaying in File Info

« on: September 24, 2024, 06:05:43 PM »

What is the file type of the files you're having issues with? As not all file formats support embedded rating metadata & aspects of wacup's rating handling will mean its only able to be stored in the local library & not the file itself. Also can you confirm if this is happening with the current preview build #20088 please.

-dro

18

Skins / Re: Anyway to fix this two skins?

« on: September 22, 2024, 12:15:22 PM »

Winamp 5.666 only made it more visible how messed up those skins were. So, the two of us do not really disagree.

Is all good & yes I agree with that & in hindsight the intent of that change like so many things was rushed in trying to do what seemed to make sense when probably it'd have been better to leave it alone but that's hindsight for you.

-dro

19

Skins / Re: Anyway to fix this two skins?

« on: September 21, 2024, 03:51:20 PM »

I'm seeing the menu issue with Vocaloid 001 also under 5.666 so that doesn't appear to be a wacup introduced issue...

Yes, the menus of many skins got messed up with the skinned menus, re-introduced in Winamp 5.666, if the value for the wasabi.window.text colour definition was the same as or very similar to the window background colour.

That's entirely down to the skinners imho. Enabling skinned menus by default was to try to make the ui more consistent within itself vs what was seemingly coming in with Windows menus vs the skinned look being at odds. So I'm going to disagree that enabling it messed things up as it can only ever go with the information that skins provide to it.

Could / should more be more done to try to avoid it yes & from a wacup stance where I've still to implement trying to read in the modern skin menu values it's going to have to wait until that for something to be attempted to try to force enough distance between the text vs background colouring (which'll be more likely to then mess things up for skins that otherwise need to be updated).

-dro

20

Skins / Re: Anyway to fix this two skins?

« on: September 21, 2024, 01:11:33 AM »

I've yet to try the modifications mentioned above (am sure they're all good) but I'm seeing the menu issue with Vocaloid 001 also under 5.666 so that doesn't appear to be a wacup introduced issue which'd match to the suggested edit to the skin.

With Vocaloid 002, that is wacup specific as part of how I've gotten 5.666's gen_ff plug-in working outside of winamp. Based on what's shown in the screenshot along with ariszlo's suggestion it'll be down to something with how I handle regions being wrong or its exposed something the skin was doing wrong.

Alas I was hoping that a fix I've got coming up for cpro skins & how layers without images are dealt with might've helped with this issue but it doesn't seem to from a quick test of the skin. Will add this to things to check out but for now would go with modifying the copy of the skin as the best way to get things fixed until I can look into the problem in my code.

-dro

21

Preview Build Discussion / Re: Streams not working in 1.99.20.19994

« on: September 19, 2024, 08:56:10 AM »

The x64 build per the notes in every beta sub-forum build thread doesn't currently have support for MP3 nor AAC streams & is something I've still to implement (x86 can since the re-used in_mp3 dll provides that support for now but needs me to finish off some of my replacement for it so the x64 build can then have that streaming support).

I'm not in a position to try the other links as of this reply & maybe they're opus based streams which is something else I've got to implement. As a lot of opus & ogg vorbis streams have the .ogg extension which at the moment confuses trying to play them & is something planned for a later build to be resolved.

-dro

22

Wishlist / Feature Requests / Re: Option to NOT include playlist items into library

« on: September 15, 2024, 02:36:31 PM »

Preferences -> Media Library -> Local Library -> Options tab -> un-check "Automatically add played files to the database
(When disabled playcounts are only stored by the history plug-in)" which iirc is in a similar place in the preferences vs what 5.666's ml_local plug-in had offered.

-dro

23

Preview Build Discussion / Re: Selection inaccuracies

« on: September 14, 2024, 12:37:32 AM »

The quantity of items being added are likely going to be the main reason vs how other aspects are then trying to get the needed metadata, etc to be able to display the separators & other playlist items as needed. Also from what I could see in the gif, the lack of a reasonable wait between double-clicks most likely means the local library -> main playlist action is still in progress when the next attempted double-click is happening along with the attempted update of the now playing indicator (since most of this is done on various background threads & the timing interactions might be off with them with all of the really quick double-clicking happening).

The separator titles not completing being updated is definitely wrong which I'll have to look into. The other aspects not being able to react fast enough & that causing the lack of the expected now playing update, etc is something I'll also need to look into though it would be useful to see if the current build 20088 makes any difference or not as it had a small change to how metadata from the local library is obtained (not done directly with this thread's issue) which may or may not help what you're experiencing.

Hopefully that makes some sense as I think it's mostly down to triggering too many of the actions too soon & they're taking a bit too long to complete vs the rate of double-clicks being attempted.

-dro

24

Preview Build Discussion / Re: Questions about Ajaxamp/Ampwifi

« on: September 12, 2024, 03:01:06 PM »

At least under older Windows installs, there'd be a dialog prompt the first time there was an attempt to make an outbound connection & what type of network / access is allowed. If that didn't appear with the WACUP instance then maybe Win11 either isn't showing such things or there's an OS / A/V setting that's defaulting to not allow it (based on the other post detailing more about the system's configuration).


So for that plug-in to be able to accessed you should only need to allow the specific port that's been configured to be used with it & not enabling full port access which shouldn't be needed & isn't something I'd ever recommend being done.

For WACUP's normal usage its typically only going to get streams its told to use or files from the WACUP site (e.g. version checking & get the internet radio updates). Since build 19994 it can also attempt to do web look-ups for lyrics & missing albumart (via the 3rd party sacad tool which needs its own access setup as applicable) but if those aren't wanted then Preferences -> General -> Internet | Online has options to control & turn them off.

The only other things typically done are the posting of the current albumart to the server if the Discord now playing option is enabled & trying to post crash reports to the site server if that happens. There is the streaming server mode but that has to be configured & enabled which is not on by default.


With the ajaxamp config problem, I'll have to see if I can figure out where the plug-in is storing its settings as I don't know if its storing things in the registry or a local file. From a quick look at the dll exports its more likely to be a local file & if I can hook the plug-in OS api calls then I might be able to apply a patch to it to be able to redirect where it saves things which would help in this instance & would help to make it be portable mode happy. As many winamp plug-ins weren't built to follow the settings folder apis (often due to pre-dating those 2.9x additions) nor accounting for multiple usage.

[edit]
Its using "%appdata%\gen_ajaxamp\gen_ajaxamp.ini" for its config file location & I seem to be able to hook the plug-in. With the next WACUP build I'll be looking to move a copy of that (if present) into %appdata%\wacup\ajaxamp.ini (assuming a default install or what equates to <wacup_settings_folder>\ajaxamp.ini) & then have things override the plug-in to look at the copy in the settings folder. That should then allow you to configure things separately & also helps to make the plug-in be portable mode friendly.

-dro

25

General Discussion / Re: Hello I'm new to the forum.

« on: September 12, 2024, 02:40:54 PM »

Ah reputation based checking. The "fun" of where to get the file you need to download it but to download it you need to already have the reputation. Little I can do about that but will keep it in mind as I know the non-MS options have also caused similar problems but there's usually been a prompt of some sort to indicate its happening unlike what appears to have happened with the Win11 implementation of nothing for you. Its also a bit weird how getting the update via the really old build doesn't seem to be checked with that so for now am going to put that in my Win11 does things that Win10 probably doesn't mental list.

-dro

26

Resolved Issues / Re: Use "AlbumArtist" and "Album Artist" tag to display Album Artist

« on: September 12, 2024, 02:34:05 PM »

thank you & fingers crossed the changes once you do another rescan are going to behave.

-dro

27

Preview Build Discussion / Re: Selection inaccuracies

« on: September 12, 2024, 12:59:50 AM »

I don't see anything obvious in my changelogs that'd explain such a behavioural difference so I don't have a fix as I currently cannot replicate it within the local library results pane (I assume that's what's meant by "main window" along with the column headers shown).

What have you got set with the Preferences -> Media library page? As maybe something is just taking longer to complete than expected but I'm not certain & I'd need to ideally find a way to replicate it & for it to consistently mess-up as shown which I'm still unable to do despite doing more testing whilst trying to make this reply.

-dro

28

Resolved Issues / Re: Use "AlbumArtist" and "Album Artist" tag to display Album Artist

« on: September 11, 2024, 10:55:20 PM »

If there was no change on refresh then I'll have a look into it later tonight as something is wrong for it not to have updated as expected.

[edit]
This issue should also be fixed for the next build - code needed got removed way back during a shared library update.  The "albumartist" field will always be the first looked for (since that's what appears to be the recommended to be used per the vague specs) with it then checking for "album artist" if "albumartist" cannot be found. I also think I've got it to correctly deal with the order within the vorbis comment tag being either way round since mp3tag would alpha sort it which put "album artist" first & that prevented "albumartist" from being used with my initial testing of the fix.

-dro

29

Resolved Issues / Re: Use "AlbumArtist" and "Album Artist" tag to display Album Artist

« on: September 11, 2024, 07:26:28 PM »

Is the local library instance new or was an existing copy from having tried wacup out previously?

If it's an existing one then I'd suggest doing a refresh of the metadata which can be done either on the items or the view or the whole of the local library via the right-click menus or the view button in the top right. As what you're seeing in the alt+3 dialog is what'd be used in the local library import / update. If it's a new instance then I'm going to have to figure out why it's failing to be read in.

I've also just finished fixing the genre issue.

-dro

30

Preview Build Discussion / Re: Questions about Ajaxamp/Ampwifi

« on: September 11, 2024, 06:47:09 PM »

Updates to the app don't prevent things working locally & it's all down to having the ajaxamp plug-in correctly installed. Additionally it likely won't behave nicely if you're trying to have WACUP & winamp open at the same time unless changing the ports that the plug-in is using in one of the installs which would then need to be altered in the ampwifi setup iirc. With seemingly quite a few using the ajaxamp plug-in under WACUP it should just be a case of installing it into the WACUP install & then it just works.


The obvious thing is to check that ajaxamp plug-in was installed into the WACUP plugins folder which from a quick re-check requires changing the install path the ajaxamp plug-in installer shows to use (since it doesn't know about wacup & as I don't try to re-use the winamp uninstall registry as was done with much older wacup builds when 5.666 was all there was, its probably not being installed).

If you're certain it is being installed into the WACUP install, go to Preferences -> Plug-ins -> General -> see if gen_ajaxamp.dll is shown in the list & that it's not indicated as either being disabled &/or unable to be loaded. If there's no trace of it then copy the dll from the winamp install into the WACUP\Plugins folder & then check that prefs page again.

If it's showing but isn't showing as normally loaded, the most obvious thing is you're using the Portable install mode & that will disable any 3rd party plug-ins from being loaded by default (since more often than not I can't guarantee they'll actually follow the portable handling). If that is the case then Preferences -> Advanced -> Portable Mode -> there'll be an option to enable 3rd party plug-ins & it'll need to be checked followed by allowing WACUP to restart so it can then load the plug-in. If there's no sign of such an option then you've not got a portable install & I'd need to know what the loading error message is for the plug-in.

-dro