15
« on: February 01, 2024, 04:15:45 PM »
meh, browser crashed on me whilst I was making a detailed reply on this so I'm going to give a quick reply so apologies if it's a bit curt.
1) I'm not seeing it still but I did find something else on an unrelated bug fix that could cause a cached title to be used at times along with a multi-threaded access issue with the shuffle list so I'm hoping fixing both of those aspects might help with this for the next build. If not then I'll have to keep trying at things.
Winamp & WACUP are different & it's more akin to Chrome vs Firefox in that the end result is the same or near enough but the way it's done to get to that differs.
2) How you're describing things, I've got to wonder if the jtf window that wacup offers is even what you've been using with winamp. As it was the default way for it from 5.04 to 5.666 unless the jtfe plug-in wasn't installed / enabled which'd then provide a simpler form that's just search box, list & close button instead of the one with the queue & manage aspects.
As everything else being raised shouldn't be new behaviour for a long time user & tbqh is leaving me somewhat more confused when the behaviour if not using the basic jtf version hasn't fundamentally changed between the jtfe plug-in when it was included with winamp & now in it's wacupified form.
3) Winamp Modern would be the most likely reason (along with my glue code to get the gen_ff plug-in to load not being the same as what winamp offered so might also be causing some issues) as not all revisions of the skin act the same & WACUP's copy is different in a number of ways to that from 5.666.
I'd completely forgotten about there being one change that I'd not gotten back around to looking at from reports a year or so ago & it relates to how the skin reacts to live bitrate changes being reported by the input plug-ins (aka how often the kbps part of the skin window updates based on a skin scripting notification it's reacting to.
That handling isn't directly linked to the skin timer aspect & with a change made to the wacup copy of that skin, it basically tries to update things as soon as it gets a notification & lots of little notifications vs how gen_ff works means higher cpu load. If I smooth out the rate of updates the WACUP core makes of the notification message that gen_ff reacts to in order to generate the skin script notification then the cpu load drops a fair bit for me & is around the same cpu level I'm seeing for the bento based skins.
Numbers wise it's typically sitting around the 0.5-1% level when playing with the odd peak to 2% or so when it was sitting around the 1-2% level with odd peaks to 4% before. Am on a 3700X so 6.25% is my peak for a core. There's some other changes applied on the glue code to get the plug-in to run under wacup which hopefully will get things down to a more reasonable level.
One thing you could try as you're comparing to 5.666 is copy the Winamp Modern skin from it into the WACUP skin's folder by giving the copy from 5.666 a different folder name so it's easier to compare against & see if that does match up to what I think is going on. The wacup core will still be useful for any of these skins as even if the skin doesn't immediately react to the information changes, the gen_ff plug-in is then having to do more work before the skins & their script timers trigger to do an information update check & trigger any of the needed ui element updates.
4) Typos on that & in a few other places should be fixed.
-dro