bugs in version 1.99.45.23528

[jvidal]

Hi!
I'm testing the latest preview and already found a couple of bugs:

1. Lyrics are not updated when the song changes (either because it ended and another one started or because you pressed the "next track" button). The only way to get the lyrics for the song currently playing is to double-click on the song entry in the playlist. and BTW, some of the lyrics are incorrect, wrong words and spelling mistakes (don't know which source is being used)

2. Whenever you click the "misc" button and select "sort by...", to sort the playlist by some criteria, then when you double click on a song in the playlist, WACUP will start playing the first song, instead of playing the song you double-clicked on. it happens every single time you sort your playlist.

I hope these can be fixed on the next preview!

cheers!

[dro]

#1, I can't replicate it not updating so is that with the lyrics plug-in wacup provides (if so what skin is being used) or is it one of the 3rd party plug-ins? If it's the one provided with wacup have you changed it to show what's selected in the playlist as that's the only way I can get it to seem like it's not behaving vs forgetting something was selected at the time.

As for the quality of the lyrics there's little I can do with my solution when there's barely any free options available to try to obtain such information online (assuming that it's also not incorrect within the file(s) being accessed as using the local copy is prioritised where possible).

#2, I can replicate but only on the first action after loading that playlist & I still need to look into what's going on to cause it.

[edit] The sorting issue is due to a workaround in place to deal with interacting with the classic skin playlist editor buttons which puts it into a wrong state when the double-click is attempted whereby it doesn't try to determine the item that's being interacted with. It's also possible to trigger playback of the current item when double-clicking in some of the dead space within the playlist window so both of those issues should now be fixed for what'll become the next preview build.

[jvidal]

hi! thanks for the reply.

For issue no.1, i'm using the default lyrics plugin and that option is checked. Another way to get the lyrics is just clicking once on the song (this way you don't have to start the song over). Looks like when the song changes or you press "next", somehow the focus is lost and the song playing is not selected on the playlist. in a very strange twist, now it's somewhat working (the lyrics change), but after clicking "next" a few times, it starts showing the lyrics for the previous song you were listening to, insted of the current one...
What skin i'm using? an old one for winamp 2.x. Maybe i'll change the skin and see if the bug persists.

as for #2, glad you could figure it out.

I can't wait for the next preview.
cheers!

[jvidal]

I think i know what's happening, the lyrics plugin is too slow, it can't keep up if you change songs in a rapid succession, so it starts showing the incorrect lyrics (also in succession)  until it finally catches up to the song you're actually listening to...

[dro]

That makes more sense especially if the online request is taking too long to get a response back or the connection is timing out which is also plausible.

As the lyrics request handling currently queues them up & then processes them in order so I'll have look into changing it so it can at least cancel any prior pending requests from the plug-in when a new one occurs which should help with some of the problem.

It doesn't resolve the online aspect being slow unless I just reduce the timeout incase that's part of the problem. As I can't remember what I've got that set to be but it might be best to lower it & not get a result (if the servers are working as the options can be hit & miss) vs lagging so badly as you're experiencing.

[dro]

I've now had a proper look into this & one of the services I'm trying to use is much slower to respond (seems they've introduced rate limiting) along with what I'm sending to it having an issue with one of the query parameters causing it to always fail those requests but also just takes a comparatively long time for it to fail. Lowering the timeout would avoid some of that but would then be more likely to never get a result back which means it'll be slow & not get anything which isn't great so other than the parameter fix that'll have to remain as-is.

With the request queue handling I've now made changes that'll remove anything that's still pending from a prior request (the one still being actioned won't abort at the moment though I may still look into that) which along with fixing the lyrics plug-in not double-checking what playlist item the handled request is coming back in from should resolve the main issue of it gradually showing the wrong information when it can be obtained.

There's still going to be a potential lag due to the initial processing vs any caching that might have already been attempted but it hopefully shouldn't now cycle through however many files might've been quickly spun through as you described was happening.

[jvidal]

glad you are making progress. I'll wait for the next preview to test it!