Latest restricted WACUP beta release is build #18654 (March 24th 2024) (x86 & x64 changelogs) | Latest WACUP public preview is build #17040 (September 30th 2023) (x86 only)


NOTE: Beta testers are added in a limited & subjective manner as I can only support so many people as part of the beta test program to keep it useful for my needs.

Unless I think you're going to be helpful, not all requests will be accepted but might still be later on. Remember that beta testing is to help me & the limitations currently works for my needs for this project.

Author Topic: Big Bento Modern v1.2  (Read 203556 times)

Eris Lund

  • The Skin Guy, Official Modern Skin tech support
  • Moderator
  • Hero Member
  • *****
  • Posts: 276
    • View Profile
    • Eris Lund's Github
Re: Big Bento Modern v1.2
« Reply #225 on: January 27, 2023, 11:39:40 PM »

Waveform Seeker exists as it should


And the option to use the integrated Waveform Seeker is also here as well
Currently building the fourth (and best) incarnation of Classic Skins in Modern Skins
https://github.com/0x5066/DeClassified
Current maintainer of the WACUP version of Winamp Modern.
https://github.com/0x5066/WinampModernPP
I made that one skin that one time.
https://github.com/0x5066/Winamp2000SP4

Der_Rio

  • Beta Tester
  • Hero Member
  • *****
  • Posts: 112
    • View Profile
Re: Big Bento Modern v1.2
« Reply #226 on: January 28, 2023, 02:04:30 PM »
Hmmm, thats strange. It's not on my version:


But Waveform Seeker itself is installed and working as seperate window:


Any idea?

Rio :)
Rio :)

Der_Rio

  • Beta Tester
  • Hero Member
  • *****
  • Posts: 112
    • View Profile
Re: Big Bento Modern v1.2
« Reply #227 on: January 28, 2023, 02:30:38 PM »
I could fix the problem!

Because it's a potable install I have to "Allow WACUP to use the OS registry as required" (in Preferences|Advanced|Portabe Mode).


Rio :)
Rio :)

dro

  • Admin / WACUP Developer
  • Administrator
  • Hero Member
  • *****
  • Posts: 4428
    • View Profile
    • WACUP (Winamp Community Update Project)
Re: Big Bento Modern v1.2
« Reply #228 on: January 28, 2023, 02:51:21 PM »
That doesn't make sense as there's nothing that should be needing to touch the OS registry when it comes to a skin specific option. As trying with the option enabled & disabled, toggling the skin provided option has the window going from being integrated to external & back again with it following the expected state. Only thing I can otherwise think of is that there's a conflict from another plug-in present but that should still exist irrespective of that option being set *confused*

-dro

Der_Rio

  • Beta Tester
  • Hero Member
  • *****
  • Posts: 112
    • View Profile
Re: Big Bento Modern v1.2
« Reply #229 on: January 28, 2023, 08:54:21 PM »
OK. I couldn't reproduce the "use OS registry" method.  :-\

So, I made a backup of my WACUP_portable folder. Then I deleted it and reinstalled latest WACUP as portable (full install). But again, no "Integrated Waveform Seeker (IWS)" option!  :o
Then I copied bit by bit from the backup to the new install.
That way I found out what was the problem:
There has to be a file
WACUP_portable\Settings\WACUP_Tools\koopa.ini

It doesn't matter what's in the file - even a 0 byte file does it.
If that file is missing (or renamed) then there is no IWS. If I recreate a file with that path and name, the IWS reappears.
100% reproducible on my system.

Rio  :)  ???
Rio :)

dro

  • Admin / WACUP Developer
  • Administrator
  • Hero Member
  • *****
  • Posts: 4428
    • View Profile
    • WACUP (Winamp Community Update Project)
Re: Big Bento Modern v1.2
« Reply #230 on: January 28, 2023, 10:31:36 PM »
Ah, I see what's going on. I'll need to edit the patching that's done on the skin version checks to avoid that (really can't remember why that file got picked with this skin for "winamp" vs wacup version detection).

-dro

Eris Lund

  • The Skin Guy, Official Modern Skin tech support
  • Moderator
  • Hero Member
  • *****
  • Posts: 276
    • View Profile
    • Eris Lund's Github
Re: Big Bento Modern v1.2
« Reply #231 on: January 28, 2023, 10:44:44 PM »
I could provide a patch for BBM with the version check I do for DeClassified (as seen here), only with Victhor's OK
Currently building the fourth (and best) incarnation of Classic Skins in Modern Skins
https://github.com/0x5066/DeClassified
Current maintainer of the WACUP version of Winamp Modern.
https://github.com/0x5066/WinampModernPP
I made that one skin that one time.
https://github.com/0x5066/Winamp2000SP4

dro

  • Admin / WACUP Developer
  • Administrator
  • Hero Member
  • *****
  • Posts: 4428
    • View Profile
    • WACUP (Winamp Community Update Project)
Re: Big Bento Modern v1.2
« Reply #232 on: January 28, 2023, 11:17:12 PM »
It's not just BBM that has this issue & there's old versions of the skins that I know are being used which are still affected. So even with a better implementation for the skin, I've still got to make changes on the core side to deal with this.

Really I need to find a way to provide a proper skin script call to use to check than all of these file existence checks as they don't work 100% but that still involves the skins being updated & means the old ways need to be dealt with.

-dro

dro

  • Admin / WACUP Developer
  • Administrator
  • Hero Member
  • *****
  • Posts: 4428
    • View Profile
    • WACUP (Winamp Community Update Project)
Re: Big Bento Modern v1.2
« Reply #233 on: January 31, 2023, 05:08:46 PM »
There's now a generic patch in place for the next beta build to deal with the file existence checks that'll do what's needed irrespective of the file existing or not.

-dro

Benco

  • Beta Tester
  • Sr. Member
  • ****
  • Posts: 39
    • View Profile
Re: Big Bento Modern v1.2
« Reply #234 on: April 15, 2023, 01:02:47 PM »
Hello,

is it OK to do a feature request for this skin?