[CHANGES MADE] CPro MMD3 won't load

[Resident_Stevil]

I'm trying to set my skin for WACUP to the CPro MMD3 skin, but for some reason when I do the window disappears and then the program locks up.  I have to delete the skin file to reset to the default skin in order to get WACUP to work normally again.  Does anybody have a fix for this?

[dro]

Can you provide a link / copy of the skin trying to be used please.

[dro]

I found a copy of the skin & it's getting stuck during skin loading due to patch I'd applied some time back to try to avoid some other modern skins causing crashes on loading so I'll need to refine that for the next build to keep everything else happy whilst allowing this one to load.

[Resident_Stevil]

Sorry I didn't reply sooner.  https://winampheritage.com/skin/cpro-mmd/221721  That's the skin I'm referring to.  I appreciate your help.

[Aminifu]

The cPro MMD skin loads and works fine for me with dev build 21946 (x86). It refused to load and caused issues with prior WACUP builds, so I didn't try to use it. I don't particularly care for SUI skins, so it wasn't a problem for me. Never the less, I'm glad it is no longer being blocked.

There is another modern skin called MMD3 developed by Sven Kistner that looks very similar to this skin. It has always worked with WACUP. It is easy to confuse these skins for each other.

[dro]

At least I'd checked the same copy of the skin (once that site provided a valid download for it) so it working from my tests & aminifu's confirmation bodes well for when the next build is made available.

[Aminifu]

One last thing. The code in WACUP that lists skins in 3 groups; classic, modern and cPro does put cPro MMD in the cPro group. But I have another cPro skin called cPro Insomnis v1.03 by Zarko Jovic that is listed with my modern skins. I'm wondering if there is anything I can do to get it listed properly.

[dro]

Having "cpro" or "cpro2" at the start of the filename is what I'm looking for since that seemed to be what they were all doing (dunno about ones that came from other sites / hosting vs skinconsortium) whereas any pre-extracted ones don't matter since the handling is looking for a ClassicPro.xml file within the skin folder.

[Aminifu]

The file was named "cPro - Insomnis.wal". I deleted the spaces in the filename and in the studio.xnf values. The skin is still listed with the modern skins. Maybe the code doesn't like the hyphen. The other skin is named "cPro_MMD.wal".

[dro]

The check looks at the immediate start of the filename so the hyphen isn't something that'd be looked at. Renaming the copy of the skin to what you've quoted works for me unless there's maybe a space at the front of it that's not obvious which would be able to break it. Otherwise I don't see why it wouldn't be working.

[edit]
I've made a change for the next build which will try to ignore spaces at the start of the string as that's the only thing I can think might be doing it though the check is never going to be 100% if someone messes with the name vs the contents inside as that's generally not viable to re-inspect the skin archive contents to figure it out all of the time vs the OS not liking slow to display menus.

[Aminifu]

Having "cpro" or "cpro2" at the start of the filename is what I'm looking for since that seemed to be what they were all doing (dunno about ones that came from other sites / hosting vs skinconsortium) whereas any pre-extracted ones don't matter since the handling is looking for a ClassicPro.xml file within the skin folder.

The filename doesn't start with a space. So you don't need to add anything to look for one. But I guess it won't hurt. I tried replacing the hyphen with an underscore and nothing changed.

I re-read the reply quoted above and even though the skin isn't pre-extracted, I decided to look for a ClassicPro.xml file in the skin's archive file. The cPro_MMD.wal had one and the cPro_Insomnis.wal didn't. I copied the file to the cPro_Insomnis.wal file and now it is listed in the cPro group.

[dro]

I copied the file to the cPro_Insomnis.wal file and now it is listed in the cPro group.

I don't think that file is used by all of the cpro skins & neither of the insomnis skins I got from winaero site had that file in them & I'd strongly suspect you've got the 'ignore the information' option on the skin -> manager settings prefs page as that's the only way I can replicate a bunch of the cpro skins not appearing under there as that will ignore aspects of the filename in the checking being attempted.

With that option enabled I'll need to do some additional checking of the skin.xml to figure out if it's cpro related or not.

Am also now aware that the prefs option mentioned isn't fitting on the same line & is wrapping making it look odd which'll be fixed.

[Aminifu]

Yes, you are correct. The ClassicPro.xml file supports a feature (custom beat vis) that the cPro_Insomnis skin does not have. So I when back to the original archive file.

The real reason the skin wasn't listed in the cPro group was that option in the skin - manager settings preferences.

[dro]

The new beta that just went up should resolve problems with that option being enabled. The fix is based on looking at the skin.xml which also caught one cpro skin for me that didn't have the cpro prefix along with showing that the Skins page list wasn't working correctly with it also enabled. With the option off then it's just going to be looking at the file / folder name & files it can see if not already extracted.

[Aminifu]

In beta build #21962 (x86), the listing of cPro skins (in the main context menu sub-menu) is now working as expected whether that skin - manager settings preferences option is enabled or not. I had enabled that option because I wanted to use it's sub-option to not show empty/invalid skins. Thank you for the fix.