[Re]enabling shuffle during playback changes "Now Playing" song

[big_keyboard]

Enabling or re-enabling shuffle during playback causes some strange behaviors.

The active track currently playing continues as usual, but the program displays a random track from the playlist — I'll refer to it as "Song 2" — as being active. Song 2 may be a track that has or has not been played yet. This behavior is reflected in the Main Window's song title area and the Playlist window. My shuffle is configured to play each song in the active playlist once and only once; however, this bug causes Song 2 to be marked as played instead of the original active track. This means that when the playlist has completed, the original active track was played a total of two times, and Song 2 may only have played if done prior to the bug.
 
I've only been able to replicate this behavior whenever the active track is listed as first in the playlist (prefixed with "1."). I'm using 1.99.16.19516 on Windows 10.

[dro]

Can confirm it only seems to be causing the visual issue on the first playlist item so that might just be an off-by-one issue in a check or it's part of having tried to avoid other complaints of it re-selecting the current song for some handling issues (i.e. always picking the first playlist item when a new shuffle list is created).

However I do need to clarify that once shuffle is toggled then any prior knowledge of what might've been played so far is essentially lost or if it was already off & then enabled there's nothing to work from. So it is possible for it to replay the current item again though I thought I'd put in some handling to try to account for this which might per my note above be why it's messing up only on the first playlist item. As shuffle is just the current playlist randomised but done in a manner so the playlist's visual order is not modified whilst allowing the playback order to be changed.

Will have a look into this properly before the next build.

-dro

[dro]

I think I've got a quick change that'll do what's needed & so far seems to behave in keeping the songticker text as expected & not changing the 'current' item from the first item to the first item in the shuffle list by avoiding immediately creating the new shuffle list until after the current item has stopped playing when playback is active. If it's not playing then it'll act like before & live update things as I just prefer that.

-dro