Messages

1

General Discussion / Re: Winamp ML import

« on: January 07, 2025, 04:31:25 PM »

I refreshed the metadata for all items and everything still looks fine.

That's good to know.

I remembered one thing, after I did the import legacy via WACUP the original db files in the Winamp folder was overwritten with an empty one. A backup of the files was created (I made my own anyway) but it was still a disturbing experience.

That's not meant to be happening & is related to the problem I found yesterday which stems from changes I'd made for my primary db file handling a while back but I missed by not fully re-testing for legacy db imports in missing that it was converting them to the newer format when that was never the intent of that mode. It should be fully resolved when the next build is ready to go up with them treated as a read-only action to avoid modification.

2

General Discussion / Re: Winamp ML import

« on: January 06, 2025, 06:57:22 PM »

Have replied to your pm with hopefully complete db files for you to work with.

For you setup the location of the files wasn't an issue but part of my testing had me trying to use a read-only folder & that was helping to show part of the problem since it prevented the conversion of the existing db files to the newer nde based format that I use before being processed for the import action. However the import shouldn't have been attempting to mess with the files & not doing that resolves the incomplete / full failures that I'd been able to replicate as part of the import plus it also makes the importing to be somewhat quicker.

3

General Discussion / Re: album art overview

« on: January 06, 2025, 04:11:49 PM »

The alternating row aspect isn't implemented because as I went with a more Explorer like approach that ends up looking odder like a chequerboard since there can be multiple on a line unlike what winamp's local library plug-in was doing. What's right I still don't know & tbh it was a pain in the whatnot to get something working that didn't suck on the performance vs OS support which I was generally happy with as a first usable form. I also don't necessarily just want to mimic what winamp's offering of things did as some aspects I never liked when I was a dev / user of it but I get that from a user view point if the outer parts are all winamp-like then there's an expectation for the insides to also be the same or more similar. I'll have a think about it all for when I get back around to doing more on the local library view modes.

4

General Discussion / Re: Winamp ML import

« on: January 06, 2025, 04:07:21 PM »

I've been able to get it to import it with what appears to be the expected total number of records (14860) along with the view specific numbers you've noted. However there's something odd going on with the import action depending on where the files are being accessed from which I'm trying to figure out at the moment which seems to be the likely explanation of why things didn't seem to import correctly.

5

Preview Build Discussion / Re: Issues opening multiple files?

« on: January 06, 2025, 01:27:10 PM »

I already have it set to disallow multiple instances from the settings by the way, so I take it it has to be a bug of some kind.
I'm on the latest public preview build as of this post, is this being looked into on betas? Or has there been attention brought to the issue already, at least?

It's come up a few times though I don't know how common of an issue it might be as I often seem to not get direct reports about issues (aka having to trawl through social media posts) so thank you for taking the time to report it.


If multiple instances are being launched then my first hunch is it might be due to a permissions issue or a form of process isolation which would then prevent the handling that's run on loading to try to find existing wacup instances to fail as that's how that stuff generally behaves afaict. It however doesn't seem to account for how you've described things as seemingly starting all of those instances at the same time instead of it being a gradual cascade from the first to last instance.

My other hunch especially with what you've described about files missing when it is already running could even be due to the processes that have been spawned potentially failing / silent crashing. This might be more likely & from feedback from one tester with the current beta vs issues seen with the preview build seemed to resolve what was a slow / laggy response to start & iirc that was sometimes causing other instances to begin due to the timeout that's in place to deal with hung / failed processes timing out.


One thing you could try out is seeing in Task Manager's details view & sorting by exe name if any werfault instances (windows error reporting handling) are appearing at around the same time as you're triggering trying to get the files into WACUP.

I also could do with knowing what skin you're using & if you're using a modern style skin another thing is to try using a classic skin just to see if the reduced loading overhead of those skins makes any difference or not (I suspect it likely won't & is something else going on).

Final thought for now is if you've got the local library enabled & if so roughly how many items are in it. As going to preferences -> media library & temporarily trying this out with the whole media library disabled might also be useful to rule out some ideas I've got.

6

General Discussion / Re: Winamp ML import

« on: January 06, 2025, 12:06:24 PM »

I'd really need to know what version of winamp you were trying to import from. As the import action I offer (accessed via the empty local library window or by going through media library window -> library button -> import -> import legacy (external) db) just needs to be pointed at an existing winamp settings folder (usually %appdata%\winamp) & as long as it's in the appropriate format then it should work.

I've only really tested the import action with copies of the local library from 5.63 to 5.666 specifically though I was given a set of main.dat/main.idx files last year from newer revision & my local library plug-in was able to import them without issue. If it's from a much older local library instance then it's most likely the layout of the columns might not be in the order that I'm expecting which would then prevent the import from seeing all of the data.

If needed you can message me a copy of the existing main.dat/main.idx from the winamp install you're trying to import so I can then check them out & if needed fix my importer &/or generate an appropriate copy of the library.dat/.idx files wacup uses for you to use with it.

7

General Discussion / Re: album art overview

« on: January 06, 2025, 11:54:49 AM »

That is what I'd expect the details view mode in my local library plug-in to currently look like as I didn't want to do a like for like replication of winamp's look for those items.

When items are selected in that mode the background colour of the text should change (as long as the skin being used defines things in a manner which makes it visually obvious) but I'm currently using a simpler way to achieve the details mode which I will need to come back to trying to expand upon but I was aiming more at just getting something that was working vs eye candy & which also worked ok under WINE based setups.

8

Preview Build Discussion / Re: Issues opening multiple files?

« on: January 02, 2025, 08:15:11 AM »

This is why I shouldn't reply at 3am in the morning when I can't sleep. Will have a proper re-read later today when I'm hopeful more with it.

9

Preview Build Discussion / Re: Issues opening multiple files?

« on: January 02, 2025, 02:55:29 AM »

What version of Windows are you using?

10

Preview Build Discussion / Re: APE Tags causing crash

« on: December 29, 2024, 03:04:23 PM »

There's now a change in place for the next build which hopefully will allow in_mp3 to behave whilst not causing a live patch that was in place to resolve another issue from occurring which appears to have been conflicting with what the input plug-in is doing with APEv2 tags.

11

Preview Build Discussion / Re: APE Tags causing crash

« on: December 29, 2024, 01:38:21 PM »

I've just had a quick look & it's crashing within the re-used in_mp3 plug-in from the 5.666 installer for which I'd been wondering what was going on. My testing is against the current beta build so really it's not WACUP build specific but is the in_mp3 plug-in at fault & is probably more luck than anything with it not having caused problems with whatever the older build was it was working for you.

The x64 build of WACUP doesn't use that plug-in though it's still to get its own proper in_mp3 replacement but it doesn't crash with that file so if you're not needing to use any of the modern style skins nor any 3rd party plug-ins then that's an option to consider using.

Will see if there's anything obvious I can do to work around whatever in_mp3 is doing as like you I'd like to see far fewer crash reports too

12

General Discussion / Re: Update library?

« on: December 21, 2024, 12:32:33 PM »

Preferences -> Media Library -> Folder Monitor or Media Library window -> Library button -> Local Library -> folder monitor section at the bottom of that (if applicable)

Right-click any of the local library nodes (root or specific will control which items are checked) or from the right-click menu within the local library views or by using the view action / settings button in the top right of the active local library view gives refresh / remove actions.

So equivalents are all there & imho there's more places to access them compared to what winamp's ml_local plug-in offered vs wacup's ml_ll.

13

Skins / Re: none of the bento skins are available?

« on: December 18, 2024, 02:33:39 PM »

It's intended for now as there's no x64 equivalent of the gen_ff plug-in that I can use & I've still to actively start working on making my own modern skin engine plug-in.

Doing that would eventually remove one of the remaining reasons for the x86 build to have to keep relying on the 5.666 installer & reusing some of it's dlls for features.

The x86 build is not a downgrade to the x64 build as it has more features & more potential support compared to the x64 build which is just the pure wacup experience for now & with more time will improve in comparison to x86.

14

Preview Build Discussion / Re: "the visualisation plug-in executed illegal operation."

« on: December 13, 2024, 03:45:55 PM »

However I'm still seeing it intermittently prevent WACUP from closing normally when the plug-in is running so I've got to look into that.

I've possibly found something that'll better allow the process to close irrespective of plug-in / external dll weirdness messing up things from what I could see with this plug-in so hopefully the next build will be better behaved on all counts.

15

Preview Build Discussion / Re: "the visualisation plug-in executed illegal operation."

« on: December 13, 2024, 12:16:22 PM »

I'd not seen the edits & luckily hadn't purged the legacy crash reports from the older builds that I do periodically though the crash didn't seem to show me much other than morphyre was trying to call something no longer there when process close was happening.

With the crash on loading, I made a change for the x64 build just before 19516 was created with how the embedded window frames are able to be created by plug-in as Morphyre uses & it messed up an expectation of how that works for the x86 plug-ins. I've now changed that back & its loading ok again. I've also fixed it to use the correctly scaled window frame so it'll match the look of the classic skin scaling.

However I'm still seeing it intermittently prevent WACUP from closing normally when the plug-in is running so I've got to look into that.