Bug when switching skins in Preview v1.99.11.18916

[wbpayne]

I've installed the newest preview build today, build 1.99.11.18916.  I'm seeing an issue when switching skins.  If I switch from a modern skin to a classic skin, and then try to switch back to a modern skin again without restarting WACUP nothing happens.  WACUP will remain using the classic skin until I restart it and then I can switch to a modern skin without issue.

This didn't occur with the previous preview build.  I'm more than happy to test any fixes that you may come up with to see if they solve this issue and am more than happy to provide any diagnostics you ask for.

Thanks,
Wilhelm Payne

[dro]

I've had another user report this earlier today despite it not having been mentioned with any of the betas from the prior few month's so I'm not sure why it'd now be messing up other than it's somewhat the nature of trying to re-use the modern skin plug-in gen_ff dll from 5.666 & something yet unknown to me isn't working right.

Compared to the old preview they are for the most part 2 different implementations now & gen_ff was never really meat to be able to work outside of a native winamp implementation as WACUP is now doing.

All I can suggest for now is to try running wacup using wacup.exe /procdump to see if there might be a weird crash happening (something that gen_ff can randomly do) & it could be that's happening & measures to try to avoid a full crash are actually working at the expense of a weird non-skin changing experience.

-dro

[MarkRH]

I did some messing around and in my case if I start with a modern (like Bento) or classic skin (Nucleo_NLog_v102_.wsz) and switch to the Built-in classic skin then it doesn't want to switch to either a modern or another classic skin afterwards unless I restart.  Going between various other classic or modern skins doesn't seem to be an issue.

I don't change skins much so not something I would have caught before. I'll try the Procdump process.

Edit: Sent a procdump in email.  Hopefully shows something related to this.

[dro]

Have now replicated the issue & am looking into what might be going on.

-dro

[dro]

There'll be a fixed build in the day or so. The problem has existed for a couple of years in my code & despite it not having been changed for the new build (haven't gone back & checked other recent beta builds) it seems to be manifesting in a more consistent manner if going to the base skin is involved as part of the chain of switching attempts.

-dro

[wbpayne]

Thank you for looking into this.  Thanks MarkRH for sending dro the procdump so quickly.  I'm glad to know that this will be fixed soon.

[Darkhell]

There'll be a fixed build in the day or so. The problem has existed for a couple of years in my code & despite it not having been changed for the new build (haven't gone back & checked other recent beta builds) it seems to be manifesting in a more consistent manner if going to the base skin is involved as part of the chain of switching attempts.

-dro

Hello, fisrt of all thanks for your great work.

Related to the skin problem i'm suffering something similar (i guess  ), in my case it only happen with Bento skin, if i change to any skin and try to go back to Bento using the skin list from right click menu it just switch to classic skin, the only way to go to bento again is opening preferences window and select bento on the skin section.

Another thing that i noticed is that i can't change the skin directory, the "Set skins directory..." button doesn't do anything, is not grayed out, it just do nothing when is pressed, tried runing wacup as admin just in case but the problem persist.

Thanks again for all your work, have a nice day

[Aminifu]

Sorry Darkhell, I'm not able to replicate your Bento skin switching issue. I can confirm that clicking the "Set skins directory..." button does nothing.

I can also confirm that the initial issue reported by wbpayne and MarkRH (which was also happening for me in the previous beta builds when switching to the base skin) is fixed in beta build #18980.

[dro]

I can confirm that clicking the "Set skins directory..." button does nothing.

Have added it to the todo list though I've not checked why it's not reacting like it should.

As for darkhell's reply, I'd need confirmation whether it's happening with 18980 or not as I can't get that failure to occur & only can with the older 18916 build which was the one out when this thread was started.

-dro

[Aminifu]

Have added it to the todo list though I've not checked why it's not reacting like it should.
...

-dro

As far as I'm concerned, take your time. I have no need or desire to change the default skins folder.

I also should stop posting in preview build threads, since I don't use it. It's just that I look at all posts and sometimes what is reported for a preview also happens with a beta.