Author Topic: [LOAD OF WORK REQUIRED] New Media Library > Album Art not working  (Read 1053 times)

joebloggscity

  • Full Member
  • ***
  • Posts: 15
    • View Profile
hi

Firstly thank you all for all the work done, and i've previously made a donation, and will do so again.

i've just downloaded the new Dec Preview build and clicked for the new media library.

However note the "Album Art " is NOT showing, just a green screen.

tried to switch back to old media library but no luck, so i just changed from Album Art to "Album".

Please can you help fix up this bug.

Any help is much appreciated, and keep up al the good work. We very much respect it.

thx
« Last Edit: December 30, 2020, 03:49:35 AM by dro »

Abhijit A

  • Beta Tester
  • Sr. Member
  • ****
  • Posts: 32
    • View Profile
Re: New Media Library > Album Art not working
« Reply #1 on: December 27, 2020, 03:31:28 PM »
Album art is yet to be implemented in new replacement media library.
While using old media library, you can edit the view and select Album art to see the proper view with artwork displayed.

if you switch to new replacement media library, ability to display album art will be lost and you will see the text columns only
« Last Edit: December 27, 2020, 04:06:38 PM by Abhijit A »

joebloggscity

  • Full Member
  • ***
  • Posts: 15
    • View Profile
Re: New Media Library > Album Art not working
« Reply #2 on: December 27, 2020, 06:51:24 PM »
okay thx, i've gone back to the old media library then for the moment

dro

  • Admin / WACUP Developer
  • Administrator
  • Hero Member
  • *****
  • Posts: 3162
    • View Profile
    • WACUP (Winamp Community Update Project)
Re: New Media Library > Album Art not working
« Reply #3 on: December 28, 2020, 04:24:42 AM »
Whatever library plug-in us being used (for which i'm assuming local library rather than parent media library based on the bit of the image I see), that green area shouldn't be present & I'll have a look into what might be going on before the new build for the coming week is released.

As the artwork view when using the non-artwork supporting local library plug-in (ml_ll) is just meant to show it as a basic list related to the filter type selected (as Abhijit noted). So a green area means something else is going wonky either with the checks made or how the view is being re-sized which is odd & a concern.

Now if this is actually due to using the new media library core (gen_ml vs what's in the wacup core) as can be toggled via the 'media library' preferences root then that's more likely to be something I've not got implemented correctly with the replacement shared skinning support. Either way I'll see what I can replicate after some sleep as trying out either of the replacement solutions shouldn't have caused the visual problem noted.

-dro

dro

  • Admin / WACUP Developer
  • Administrator
  • Hero Member
  • *****
  • Posts: 3162
    • View Profile
    • WACUP (Winamp Community Update Project)
Re: New Media Library > Album Art not working
« Reply #4 on: December 30, 2020, 03:49:12 AM »
I've now had more of a look & the problem is that my replacement skinning code (which is separate from the media library core) doesn't implement the custom window type that ml_local is using for drawing the artwork. It seems that is also shared with ml_pmp from a quick string search of the dlls as well as a second custom window type which I assume is to cover icon mode vs details mode in a cleaner manner than doing it all together.

That puts me in a tricky position as I've got to implement something which isn't necessarily how I want to do artwork in the library views but will allow the view to be drawn rather than showing a blank area (as right-clicking will work but is mostly useless if you can't determine what you're interacting with).

As such I've got work to do with finishing off ml_ll to have it's own artwork support but to also avoid ml_pmp breaking (as I want to drop the use of gen_ml soon) then I'm going to have to find a solution. Oh the joys of the library plug-ins & the things they want.

-dro

joebloggscity

  • Full Member
  • ***
  • Posts: 15
    • View Profile
Re: [LOAD OF WORK REQUIRED] New Media Library > Album Art not working
« Reply #5 on: December 30, 2020, 02:14:20 PM »
oops!  ;)

Thanks for all the help and speedy responses, let me know if you ever need any help. I've gone back to the old media library. No problems with that one.

dro

  • Admin / WACUP Developer
  • Administrator
  • Hero Member
  • *****
  • Posts: 3162
    • View Profile
    • WACUP (Winamp Community Update Project)
Re: [LOAD OF WORK REQUIRED] New Media Library > Album Art not working
« Reply #6 on: December 30, 2020, 02:51:27 PM »
It's fine as this is the point of testing to find things that I've missed / not thought about especially with some aspects of compatibility needed.

Ultimately I need to drop ml_local for ml_ll asap as ml_local is one of the top reasons for crashes that I'm seeing & for a better WACUP experience, ml_local is a stone around it's neck at this point.

-dro

dro

  • Admin / WACUP Developer
  • Administrator
  • Hero Member
  • *****
  • Posts: 3162
    • View Profile
    • WACUP (Winamp Community Update Project)
Re: [LOAD OF WORK REQUIRED] New Media Library > Album Art not working
« Reply #7 on: December 30, 2020, 10:31:29 PM »
I've had a quick go at trying to quickly make it show the basic listview instead of the empty space but I'd need more time to do that (which would be better spent on just getting at least ml_ll doing artwork).

So for the interim it's going to show as something like this when using the new media library core with ml_local or ml_pmp is set to display the visual albumart filter in their views.

-dro
« Last Edit: December 30, 2020, 10:36:31 PM by dro »