[CHANGES MADE] Visualizer steals focus for Media Keys (Stop/Start etc)

  • 6 Replies
  • 237 Views
*

ferropop

  • Newbie
  • *
  • 3
    • View Profile
If the Visualizer is focused, it prevents WACUP from receiving keys like Space (stop/start), forcing you to have to click on the player window to refocus...essentially defeating the purpose of using the keyboard.
« Last Edit: July 30, 2020, 04:43:47 AM by dro »

*

Gordon Freeman

  • Almost a full-time hobby Modern Skinner
  • Beta Tester
  • Jr. Member
  • **
  • 85
    • View Profile
    • Gordon Freeman's Github
Re: Visualizer steals focus for Media Keys (Stop/Start etc)
« Reply #1 on: July 17, 2020, 07:09:07 PM »
Which Visualizer plug-in were you running?
I made that one skin that one time.
https://github.com/The1Freeman/Winamp2000SP4

*

ferropop

  • Newbie
  • *
  • 3
    • View Profile
Re: Visualizer steals focus for Media Keys (Stop/Start etc)
« Reply #2 on: July 17, 2020, 10:24:46 PM »
MilkDrop.

Win10 LTSC.

*

dro

  • Admin / WACUP Developer
  • Administrator
  • Hero Member
  • *****
  • 2414
    • View Profile
    • WACUP (Winamp Community Update Project)
Re: Visualizer steals focus for Media Keys (Stop/Start etc)
« Reply #3 on: July 18, 2020, 01:06:21 AM »
Because Milkdrop does things related to keyboard input (e.g. preset menu navigation & a few other things), it doesn't generically pass on keyboard presses it receives but doesn't handle to the main window unlike most of the other plug-in windows that WACUP provides.

The space key is used by Milkdrop in a long standing action to pick a different preset to render. I get that is at conflict of the usage of space within other changes that WACUP have introduced but I'm not sure about changing the default Milkdrop handling.

So I'm not sure what the best approach is to take with this.

-dro

*

ferropop

  • Newbie
  • *
  • 3
    • View Profile
Re: Visualizer steals focus for Media Keys (Stop/Start etc)
« Reply #4 on: July 18, 2020, 10:11:55 PM »
Because Milkdrop does things related to keyboard input (e.g. preset menu navigation & a few other things), it doesn't generically pass on keyboard presses it receives but doesn't handle to the main window unlike most of the other plug-in windows that WACUP provides.

The space key is used by Milkdrop in a long standing action to pick a different preset to render. I get that is at conflict of the usage of space within other changes that WACUP have introduced but I'm not sure about changing the default Milkdrop handling.

So I'm not sure what the best approach is to take with this.

-dro

Totally fair - would a key remap option be in the cards? Winamp (and now Reaper!) has championed customization from the beginning, and it would be great for those of us looking to really get in there to 'unmap' Space in Milkdrop to free it for it's new (much improved!) use.

*

dro

  • Admin / WACUP Developer
  • Administrator
  • Hero Member
  • *****
  • 2414
    • View Profile
    • WACUP (Winamp Community Update Project)
Re: Visualizer steals focus for Media Keys (Stop/Start etc)
« Reply #5 on: July 20, 2020, 01:21:52 AM »
What I'll do is if the prefs option is set then milkdrop will adhere to it if stop/start is set & if not then it'll act like it's always done. That makes the most sense now I've had a bit more time to think about it especially as it'll still be possible to use shift/control + space (as there's nothing in the code to differentiate from those cases vs a plain space action) so only a minor behavioural change assuming its even an issue to start with.

-dro
« Last Edit: July 20, 2020, 01:41:10 AM by dro »

*

dro

  • Admin / WACUP Developer
  • Administrator
  • Hero Member
  • *****
  • 2414
    • View Profile
    • WACUP (Winamp Community Update Project)
The changes for this are present in build 5864 & newer.

-dro