Unicode Taskbar Title

  • 3 Replies
  • 2724 Views
*

Sara

  • Beta Tester
  • Full Member
  • ***
  • 11
    • View Profile
Unicode Taskbar Title
« on: October 26, 2019, 12:42:56 PM »
Winamp and WACUP both support Unicode titles and artists in tags, and these display correctly in the player itself, but in the case of WACUP, the taskbar does not correctly display Unicode at all and seems to display based on the current codepage instead. Code this be modified to use Unicode window functions so that the taskbar title can also display Unicode? The way it is right now is really awkward for (for example) Japanese track names in Western codepages.

*

dro

  • Admin / WACUP Developer
  • Administrator
  • Hero Member
  • *****
  • 2517
    • View Profile
    • WACUP (Winamp Community Update Project)
Re: Unicode Taskbar Title
« Reply #1 on: October 26, 2019, 05:35:55 PM »
It should be showing unicode characters correctly as there's a number of measures in place to force it to do so (more than the implementation that I'd provided for 5.666 would do) unless a 3rd party plug-in has been installed that is managing to circumvent that & trigger the OS to use the non-unicode methods.

Can you please provide an info tool report (via the plug-ins root preference page) so I can get a better idea of the WACUP install.

-dro

*

Sara

  • Beta Tester
  • Full Member
  • ***
  • 11
    • View Profile
Re: Unicode Taskbar Title
« Reply #2 on: November 11, 2019, 08:04:00 AM »
Sorry for the delay in my response; I've been on vacation.

I'm not sure how that could be that it would be related at all to anything 3rd-party as for me it reproduces even playing a file in a brand-new and unmodified portable version installation. It works everywhere except the taskbar, where Japanese symbols in (Unicode, of course) filenames or (Unicode) tags are turned into question marks, as if SetWindowTextA were being used instead of SetWindowTextW (just for example). I don't have this same issue with Winamp.

I've pasted in a report from a fresh portable installation where the problem occurs. Please advise!

Edit: I have determined that the cause of this lays in gen_win10shell.dll as disabling it fixes the issue. The DLL in question is the unmodified, stock gen_win10shell.dll included with WACUP. I appreciate the functionality this DLL brings and would prefer a fix over disabling it.

Code: [Select]
-------------------------------------------------
Winamp Info Report
-------------------------------------------------

File was generated by Winamp Info Tool v6.3.0.6332  on: 11-11-2019 at: 03:01:57
© 2011-2019 Christoph Grether

-------------------------------------------------
General Information
-------------------------------------------------

Windows Version: Windows 10 Pro (64-Bit)
System Language: English (United States)
Internet Explorer Version: Internet Explorer is not present on the system
Winamp Version: 5.6.6.3516 (Winamp Standard Version)
Winamp Community Update Project (WACUP) Version: 1.0.8.4346
Winamp Backup Tool Version: Winamp Backup Tool is not present on the system
Winamp Tray Control Icon Pack Version: Winamp Tray Control Icon Pack is not present on the system
Sonic Burning Engine Version: Sonic Engine is not present on the system
Current Skin: Winamp Classic
Current Language Pack: None
Current Output Plug-in: Nullsoft DirectSound Output [out_ds.dll]
Current Visualization Plug-in: MilkDrop 2 [vis_milk2.dll]
Current DSP Plug-in: None
Current CD Ripping Encoding Plug-in: None
Current Transcoder Encoding Plug-in: None
Current File Type Icon Library: None
Current Tray Control Icon Pack: None

-------------------------------------------------
Winamp Directories
-------------------------------------------------

Winamp Installation Path: G:\WACUP
Winamp Configuration Path: G:\WACUP\Settings
Winamp Backup Path: No Backup directory available
Winamp Plug-in Path: G:\WACUP\Plugins
Winamp System Components Path: G:\WACUP\System
Winamp Skins Path: G:\WACUP\Skins
Winamp Language Pack Path: No Language Pack directory available
Winamp Visualization Plug-in Path: G:\WACUP\Plugins
Winamp DSP Plug-in Path: G:\WACUP\Plugins
Winamp File Type Icon Library Path: No File Type Icon directory available
Winamp Tray Control Icon Pack Path: No Tray Control Icon directory available
MilkDrop Presets Path: No MilkDrop presets directory available
AVS Presets Path: No AVS presets directory available
Portable Players Destination Path: Using the CD-Ripping Destination Path (%USERPROFILE%\Music)
Portable Players File Naming Scheme: Using the CD-Ripping File Naming Scheme (<Artist> - <Album>\## - <Title>)
Winamp Configuration File Path: G:\WACUP\Settings\winamp.ini
Media Library Configuration File Path: G:\WACUP\Settings\Plugins\gen_ml.ini

-------------------------------------------------
Winamp General Settings
-------------------------------------------------

Internet Connection Settings: Always Connected (LAN, DSL, Cable)
Taskbar/Notification Area Presence: Winamp is shown in Taskbar only
Priority Class: Normal
Visualization Plug-in Priority: Normal
Allow Multiple Instances: Disabled
Always on Top: Disabled
Recycle permanently deleted files: Disabled
Prevent the mouse wheel from altering the volume: Disabled

-------------------------------------------------
Winamp Playlist Settings
-------------------------------------------------

Repeat Mode: Repeat Mode and Manual Playlist Advance disabled (Repeat None)
Shuffle Mode: Disabled
Current Playlist Font: Arial
Current Playlist Font Size: 11 Pixels
Current Playlist Text Direction: Force left-to-right order
Show Numbers in Playlist: Disabled
Metadata Reading: Metadata will be read, when file(s) are played or viewed in Playlist Editor
Current ATF String: [%artist% - ]$if2(%title%,$filepart(%filename%))

-------------------------------------------------
Winamp Playback Settings
-------------------------------------------------

Volume: 0%
Speaker Balance: Center
Playback Thread Priority: Highest (Default)
Output Bit Depth: 16 Bit Output
Surround Sound: Disabled
Dithering: Disabled
Forced Mono Output: Disabled
ReplayGain Support: Disabled
Equalizer: Disabled
Preamp: +0.0 db
Buffer length: 2000 ms
Prebuffer on start / seek / underrun: 500 ms
Buffer-ahead on track change: 500 ms
Crossfading at start: Disabled
Crossfading on first start: Disabled
Crossfading at end of song: Disabled
Crossfading on Pause/Stop: Disabled
Crossfading On Seek: Disabled
Remove silence at the beginning/end of track: Enabled (Cuttoff: -40 db)

-------------------------------------------------
Registered File Extensions
-------------------------------------------------

There are no file extensions associated with Winamp

-------------------------------------------------
Winamp Input Plug-ins
-------------------------------------------------

in_ape.dll ◆
Version: 4.92.8 | Size: 88.00 KiB

in_audio.dll ◆
Version: 1.1.5 | Size: 12.50 KiB

in_capture.dll ◆
Version: 2.2 | Size: 108.50 KiB

in_cdda.dll ◆
Version: 0.9.8.3 | Size: 88.50 KiB

in_dshow.dll ★
Version: 1.13 | Size: 71.50 KiB

in_flac.dll ◆
Version: 1.1.1 | Size: 43.50 KiB

in_midi.dll ★
Version: 3.55 | Size: 109.50 KiB

in_mod.dll ◆
Version: 0.4.9.12139 | Size: 637.00 KiB

in_mp3.dll ★
Version: 4.103 | Size: 263.50 KiB

in_mp4.dll ◆
Version: 1.3.6 | Size: 182.00 KiB

in_nsv.dll ★
Version: 1.75 | Size: 76.00 KiB

in_sidious.dll ◆
Version: 2.1.5.7 | Size: 203.50 KiB

in_text.dll ◆
Version: 2.9.1 | Size: 35.00 KiB

in_url.dll ◆
Version: 1.5.1 | Size: 87.50 KiB

in_vgmstream.dll ◆
Version: 2.1.2466 | Size: 1.28 MiB

in_vorbis.dll ◆
Version: 1.2.2 | Size: 49.50 KiB

in_wav.dll ◆
Version: 1.4.1 | Size: 15.50 KiB

in_wave.dll ◆
Version: 1.0.4 | Size: 15.50 KiB

in_wv.dll ◆
Version: 5.1.0.6 | Size: 70.00 KiB

in_zip.dll ◆
Version: 1.3.5 | Size: 61.50 KiB

in_wav.trb ★
Version: 2.0.6 | Size: 31.50 KiB

➝ Total: 21 File(s) | 3.48 MiB

-------------------------------------------------
Winamp Output Plug-ins
-------------------------------------------------

out_disk.dll ★
Version: 2.18 | Size: 24.00 KiB

out_ds.dll ★
Version: 2.64 | Size: 52.50 KiB

out_ignorant.dll ◆
Version: 1.0.1 | Size: 6.50 KiB

out_notsoasio.dll ◆
Version: 1.1 | Size: 88.50 KiB

out_notsoyasapi.dll
Version: 1.1.3 | Size: 51.00 KiB

out_wave.dll ★
Version: 2.17 | Size: 19.50 KiB

➝ Total: 6 File(s) | 242.00 KiB

-------------------------------------------------
Winamp Vizualization Plug-ins
-------------------------------------------------

vis_classic.dll ◆
Version: 2.0.2 | Size: 65.50 KiB

vis_milk2.dll ◆
Version: 2.26.11 | Size: 428.00 KiB

➝ Total: 2 File(s) | 493.50 KiB

-------------------------------------------------
Winamp DSP / Effects Plug-ins
-------------------------------------------------

dsp_wc.dll ◆
Version: 1.2.4 | Size: 70.00 KiB

➝ Total: 1 File(s) | 70.00 KiB

-------------------------------------------------
Winamp General Purpose Plug-ins
-------------------------------------------------

gen_3mode.dll ◆
Version: 1.5.5 | Size: 9.00 KiB

gen_bigclock.dll ◆
Version: 1.3.4 | Size: 22.00 KiB

gen_classic.dll ◆
Version: 2.1.8 | Size: 25.50 KiB

gen_classicart.dll ◆
Version: 1.8.5 | Size: 25.00 KiB

gen_exclude.dll ◆
Version: 1.2.4 | Size: 19.50 KiB

gen_ff.dll ★
Version: 1.49 | Size: 1.63 MiB

gen_hotkeys.dll ◆
Version: 2.4 | Size: 47.00 KiB

gen_jumpex.dll ◆
Version: 1.7.5.1452 | Size: 131.50 KiB

gen_ml.dll ★
Version: 3.75 | Size: 318.50 KiB

gen_nos.dll ◆
Version: 1.3.11 | Size: 8.50 KiB

gen_play_remove.dll ◆
Version: 3.1.5 | Size: 40.00 KiB

gen_repeater.dll ◆
Version: 1.2.3 | Size: 14.00 KiB

gen_skinmanager.dll ◆
Version: 1.6.7 | Size: 62.50 KiB

gen_timerestore.dll ◆
Version: 3.1 | Size: 26.50 KiB

gen_transcode.dll ◆
Version: 1.0.12 | Size: 47.50 KiB

gen_undo.dll ◆
Version: 1.4.3 | Size: 33.50 KiB

gen_waveseek.dll ◆
Version: 3.5.3 | Size: 40.00 KiB

gen_wc.dll ◆
Version: 0.2.9 | Size: 48.00 KiB

gen_win10shell.dll ◆
Version: 1.0.1 | Size: 39.50 KiB

gen_win7shell.dll ◆
Version: 3.1.5 | Size: 111.00 KiB

gen_yule.dll ◆
Version: 2.3.2 | Size: 161.50 KiB

➝ Total: 21 File(s) | 2.83 MiB

-------------------------------------------------
Winamp Media Library Plug-ins
-------------------------------------------------

ml_bookmarks.dll ◆
Version: 2.2.2 | Size: 57.50 KiB

ml_devices.dll ★
Version: 1.34 | Size: 152.00 KiB

ml_exporter.dll ◆
Version: 1.2.3 | Size: 34.50 KiB

ml_history.dll ◆
Version: 1.4.8 | Size: 53.50 KiB

ml_ll.dll ◆
Version: 1.0.4.1 | Size: 169.50 KiB

ml_local.dll ★
Version: 3.32 | Size: 317.00 KiB

ml_playlists.dll ◆
Version: 2.8.4 | Size: 185.00 KiB

ml_pmp.dll ★
Version: 2.24 | Size: 280.00 KiB

ml_radio.dll ◆
Version: 1.5.4 | Size: 92.50 KiB

ml_rg.dll ◆
Version: 1.3.9 | Size: 304.50 KiB

ml_wire.dll ◆
Version: 2.18 | Size: 201.00 KiB

➝ Total: 11 File(s) | 1.80 MiB

-------------------------------------------------
Winamp Portable Media Player Plug-ins
-------------------------------------------------

pmp_ipod.dll ★
Version: 0.88 | Size: 157.00 KiB

pmp_mtp.dll ★
Version: 0.99.1 | Size: 111.00 KiB

pmp_njb.dll ★
Version: 0.57 | Size: 20.50 KiB

pmp_usb.dll ★
Version: 1.61 | Size: 52.00 KiB

➝ Total: 4 File(s) | 340.50 KiB

-------------------------------------------------
Winamp Encoder Plug-ins
-------------------------------------------------

enc_fhgaac.dll ★
Version: 1.0.8 | Size: 1020.50 KiB

enc_flac.dll ◆
Version: 1.0.3 | Size: 13.00 KiB

enc_mp3.dll ◆
Version: 1.0.4 | Size: 14.00 KiB

enc_opus.dll ◆
Version: 1.0.2 | Size: 26.00 KiB

enc_vorbis.dll ◆
Version: 1.0.1 | Size: 14.00 KiB

enc_wav.dll ★
Version: 1.0.2.1 | Size: 14.00 KiB

➝ Total: 6 File(s) | 1.08 MiB

-------------------------------------------------
Winamp System Components
-------------------------------------------------

aacdec.w5s ★
Version: 5.6.6.3516 | Size: 902.00 KiB

albumart.w5s ◆
Version: 1.7.0.0 | Size: 23.00 KiB

ClassicPro.w5s
Version: 2.0.3.0 | Size: 127.00 KiB

devices.w5s ★
Version: 5.6.6.3516 | Size: 33.50 KiB

dlmgr.w5s ◆
Version: 1.1.4.0 | Size: 24.50 KiB

h264.w5s ★
Version: 5.6.6.3516 | Size: 666.50 KiB

image.w5s ◆
Version: 1.6.1.0 | Size: 547.00 KiB

jnetlib.w5s ◆
Version: 2.0.5.0 | Size: 26.00 KiB

metadata.w5s ◆
Version: 0.3.5.0 | Size: 24.50 KiB

mp4v.w5s ★
Version: 5.6.6.3516 | Size: 203.00 KiB

pcm.w5s ★
Version: 5.6.6.3516 | Size: 13.50 KiB

playlist.w5s ◆
Version: 3.3.7.0 | Size: 89.00 KiB

tagz.w5s ◆
Version: 1.2.0.0 | Size: 20.50 KiB

timer.w5s ★
Version: 5.6.4.0 | Size: 26.50 KiB

vlb.w5s ★
Version: 5.6.6.3516 | Size: 122.50 KiB

vp6.w5s ★
Version: 5.6.6.3516 | Size: 178.50 KiB

vp8.w5s ★
Version: 5.6.6.3516 | Size: 230.50 KiB

xml.w5s ◆
Version: 2.2.8.0 | Size: 117.00 KiB

freetype.wac ★
Version: - | Size: 326.00 KiB


-------------------------------------------------
Winamp DLL Files
-------------------------------------------------

elevate.dll ◆
Version: 1.0.8.4346 | Size: 7.50 KiB

libcurl.dll
Version: 7.66.0.0 | Size: 2.08 MiB

libFLAC.dll ◆
Version: 1.3.3.0 | Size: 183.50 KiB

libmp4v2.dll ◆
Version: 1.0.0.0 | Size: 153.50 KiB

libopus.dll ◆
Version: 1.3.1.0 | Size: 222.00 KiB

libsndfile.dll ◆
Version: 1.0.29.1 | Size: 343.50 KiB

libvorbis.dll ◆
Version: 1.3.6.0 | Size: 647.00 KiB

lzma.dll ◆
Version: 19.0.0.1 | Size: 30.00 KiB

ml_res.dll
Version: 1.0.8.4346 | Size: 14.00 KiB

mpg123.dll
Version: - | Size: 144.50 KiB

msvcp140.dll
Version: 14.16.27033.0 | Size: 439.48 KiB

nde.dll ◆
Version: 2.3.1.0 | Size: 58.00 KiB

nsutil.dll ★
Version: 5.6.6.3516 | Size: 409.00 KiB

nxlite.dll ★
Version: 5.6.6.3516 | Size: 28.50 KiB

soxr.dll ◆
Version: 0.1.3.0 | Size: 127.00 KiB

SystemMediaTransportControl.dll ◆
Version: 1.1.0.0 | Size: 16.50 KiB

tag.dll ◆
Version: 1.1.1.4 | Size: 557.00 KiB

tataki.dll ★
Version: 5.6.6.3516 | Size: 86.50 KiB

unrar.dll ◆
Version: 5.80.2.3196 | Size: 155.00 KiB

vcruntime140.dll
Version: 14.16.27033.0 | Size: 78.98 KiB

winamp.dll ◆
Version: 1.0.8.4346 | Size: 872.00 KiB

winamp_res.dll
Version: 1.0.8.4346 | Size: 194.00 KiB

zlib.dll ◆
Version: 1.2.11.3 | Size: 102.50 KiB

msvcp90.dll ◆
Version: 9.0.30729.6161 | Size: 556.33 KiB

msvcr90.dll ★
Version: 9.0.30729.6161 | Size: 637.83 KiB

at3plusdecoder.dll
Version: - | Size: 328.50 KiB

avcodec-vgmstream-58.dll
Version: 58.43.100.0 | Size: 1.90 MiB

avformat-vgmstream-58.dll
Version: 58.25.100.0 | Size: 703.01 KiB

avutil-vgmstream-56.dll
Version: 56.25.100.0 | Size: 603.51 KiB

libatrac9.dll
Version: - | Size: 40.00 KiB

libcelt-0061.dll
Version: - | Size: 34.50 KiB

libcelt-0110.dll
Version: - | Size: 50.50 KiB

libg719_decode.dll ◆
Version: - | Size: 49.00 KiB

libg7221_decode.dll ◆
Version: - | Size: 46.00 KiB

nsvdec_vp3.dll ★
Version: 5.6.6.3516 | Size: 100.50 KiB

nsvdec_vp5.dll ★
Version: 5.6.6.3516 | Size: 170.50 KiB

lame_enc.dll ◆
Version: 3.100.2.1 | Size: 164.50 KiB

read_file.dll ★
Version: 5.6.6.3516 | Size: 84.00 KiB

d3dx9_31.dll
Version: 9.15.779.0 | Size: 2.30 MiB

D3DX9_42.dll
Version: 9.27.952.3001 | Size: 1.80 MiB


-------------------------------------------------
Winamp Language Packs (.wlz)
-------------------------------------------------

None installed

-------------------------------------------------
Winamp Language Files (.lng)
-------------------------------------------------

None installed

-------------------------------------------------
Winamp Classic Skins (.wsz)
-------------------------------------------------

None installed

-------------------------------------------------
Winamp Modern Skins (.wal)
-------------------------------------------------

None installed

-------------------------------------------------
Winamp Skins (.zip)
-------------------------------------------------

None installed

-------------------------------------------------
Winamp Skins (in a Folder)
-------------------------------------------------

Bento [Size: 288.20 KiB]
Big Bento [Size: 830.05 KiB]
Big Bento Modern [Size: 2.65 MiB]
Big Bento Modern Light [Size: 893.55 KiB]
Big Bento Modern Windows 10 Edition [Size: 2.28 MiB]
Big Bento Modern Windows 10 Edition Light [Size: 1.35 MiB]
Winamp Classic Modern [Size: 895.03 KiB]
Winamp Modern [Size: 911.81 KiB]
Winamp Modern Holiday [Size: 78.93 KiB]

➝ Total: 9 File(s) | 10.09 MiB

-------------------------------------------------
MilkDrop Presets
-------------------------------------------------

None installed

-------------------------------------------------
AVS Presets
-------------------------------------------------

None installed

-------------------------------------------------
Winamp File Type Icon Libraries
-------------------------------------------------

None installed

-------------------------------------------------
Winamp Tray Control Icon Packs
-------------------------------------------------

None installed

-------------------------------------------------
Winamp Backups
-------------------------------------------------

No Winamp Backups present

-------------------------------------------------
Legend
-------------------------------------------------

●●● Hidden user name
★ Official shipped component
◆ Official shipped WACUP component
(!) Component with known compatibility issues

-------------------------------------------------
End of Report
-------------------------------------------------
« Last Edit: November 11, 2019, 08:14:53 AM by Sara »

*

dro

  • Admin / WACUP Developer
  • Administrator
  • Hero Member
  • *****
  • 2517
    • View Profile
    • WACUP (Winamp Community Update Project)
Re: Unicode Taskbar Title
« Reply #3 on: November 11, 2019, 07:27:20 PM »
I had to ask as without knowing the install I couldn't be certain if it was just WACUP provided plug-ins or not (I've seen external programs that inject into running processes also mess up the subclass handling which is the normal reason for the failure).

Thanks to what you've determined, it's the C# dll that goes along with the win10shell plug-in that is causing the failure (going for SetWindowLongA instead of SetWindowLongW for the subclass).

I'll get the issue fixed for the next build & thanks for reporting the issue as it's appreciated.

-dro